Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables #595

Merged
merged 2 commits into from
May 14, 2024
Merged

Rename variables #595

merged 2 commits into from
May 14, 2024

Conversation

JulianGCalderon
Copy link
Contributor

Renames some variables to improve code legibility

Copy link

github-actions bot commented May 14, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.307 ± 0.055 11.254 11.446 25.88 ± 0.31
cairo-native (embedded AOT) 1.579 ± 0.011 1.560 1.603 3.62 ± 0.05
cairo-native (embedded JIT using LLVM's ORC Engine) 1.554 ± 0.011 1.535 1.568 3.56 ± 0.05
cairo-native (standalone AOT) 0.636 ± 0.001 0.634 0.638 1.46 ± 0.02
cairo-native (standalone AOT with -march=native) 0.437 ± 0.005 0.433 0.450 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.633 ± 0.070 10.581 10.817 1307.87 ± 17.10
cairo-native (embedded AOT) 1.105 ± 0.009 1.088 1.120 135.86 ± 1.92
cairo-native (embedded JIT using LLVM's ORC Engine) 1.118 ± 0.004 1.114 1.126 137.51 ± 1.63
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.008 1.01 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.008 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.896 ± 0.013 1.883 1.926 27.76 ± 0.28
cairo-native (embedded AOT) 1.262 ± 0.010 1.249 1.283 18.49 ± 0.20
cairo-native (embedded JIT using LLVM's ORC Engine) 1.536 ± 0.052 1.448 1.602 22.49 ± 0.77
cairo-native (standalone AOT) 0.112 ± 0.001 0.112 0.114 1.64 ± 0.01
cairo-native (standalone AOT with -march=native) 0.068 ± 0.000 0.068 0.070 1.00

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (e89d38a) to head (1fdd8dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   88.63%   88.63%           
=======================================
  Files         109      109           
  Lines       34905    34905           
=======================================
  Hits        30938    30938           
  Misses       3967     3967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanbono juanbono added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 60796b9 May 14, 2024
9 checks passed
@juanbono juanbono deleted the rename-variables branch May 14, 2024 21:31
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 15, 2024
* Rename variables

* Rename variable in comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants