Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor uint512 to use blockext #562

Merged
merged 5 commits into from
May 7, 2024
Merged

Refactor uint512 to use blockext #562

merged 5 commits into from
May 7, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented May 2, 2024

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@edg-l edg-l changed the base branch from main to enable_more_tests May 2, 2024 13:39
Copy link

github-actions bot commented May 2, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.511 ± 0.080 13.417 13.689 31.03 ± 0.23
cairo-native (embedded AOT) 1.575 ± 0.014 1.549 1.601 3.62 ± 0.04
cairo-native (embedded JIT using LLVM's ORC Engine) 1.552 ± 0.016 1.529 1.574 3.56 ± 0.04
cairo-native (standalone AOT) 0.638 ± 0.003 0.635 0.646 1.46 ± 0.01
cairo-native (standalone AOT with -march=native) 0.435 ± 0.002 0.434 0.440 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.011 ± 0.098 12.918 13.265 1606.38 ± 21.26
cairo-native (embedded AOT) 1.095 ± 0.008 1.080 1.105 135.21 ± 1.78
cairo-native (embedded JIT using LLVM's ORC Engine) 1.116 ± 0.010 1.104 1.136 137.77 ± 1.97
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.01 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.008 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.897 ± 0.008 1.885 1.910 27.85 ± 0.21
cairo-native (embedded AOT) 1.207 ± 0.011 1.186 1.229 17.72 ± 0.20
cairo-native (embedded JIT using LLVM's ORC Engine) 1.439 ± 0.009 1.429 1.458 21.12 ± 0.18
cairo-native (standalone AOT) 0.112 ± 0.000 0.111 0.112 1.64 ± 0.01
cairo-native (standalone AOT with -march=native) 0.068 ± 0.000 0.068 0.070 1.00

azteca1998
azteca1998 previously approved these changes May 2, 2024
@edg-l edg-l force-pushed the enable_more_tests branch 2 times, most recently from aa51dd2 to bc9820e Compare May 6, 2024 14:09
Base automatically changed from enable_more_tests to main May 7, 2024 11:49
@juanbono juanbono dismissed azteca1998’s stale review May 7, 2024 11:49

The base branch was changed.

@juanbono juanbono added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 4d1b408 May 7, 2024
9 checks passed
@juanbono juanbono deleted the refactor_uint512 branch May 7, 2024 23:22
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 15, 2024
* fix segfault when a snapshot of a box is taken

* enable test

* enable more corelib tests, like keccak ones

* refactor u512 to use blockext

---------

Co-authored-by: Iñaki Garay <igarai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants