Refactor pedersen libfuncs to use the BlockExt trait #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAdev0
requested review from
edg-l,
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
azteca1998
reviewed
Apr 23, 2024
|
@azteca1998 comments addressed, tests are passing. Ready for review! |
azteca1998
previously approved these changes
Apr 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 88.85% 88.84% -0.02%
==========================================
Files 108 108
Lines 34555 34535 -20
==========================================
- Hits 30705 30681 -24
- Misses 3850 3854 +4 ☔ View full report in Codecov by Sentry. |
|
@azteca1998 I had a bunch of useless |
fmoletta
approved these changes
Apr 29, 2024
azteca1998
approved these changes
May 6, 2024
|
Ready to be merged @azteca1998 @fmoletta |
igaray
approved these changes
May 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
juanbono
approved these changes
May 8, 2024
Gerson2102
pushed a commit
to Gerson2102/cairo_native
that referenced
this pull request
May 15, 2024
* refactor pedersen * fix * temp commit * address comments * temp * remove useless into --------- Co-authored-by: Edgar <git@edgarluque.com>
Gerson2102
pushed a commit
to Gerson2102/cairo_native
that referenced
this pull request
May 15, 2024
* refactor pedersen * fix * temp commit * address comments * temp * remove useless into --------- Co-authored-by: Edgar <git@edgarluque.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #529
Checklist