-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bitwise libfuncs to use the BlockExt trait #520
Comments
Hello, can i work on this one? And btw i still figuring out what i have to do. |
@edg-l I've reviewed the PR and understand the refactor that's being implemented. If this task becomes available, I'm ready to jump in. |
@edg-l hello mate. I have a question in this issue. I think that i understand what i have to do. But something that i still dont get it, is the fact that, the functions that can be refactored regards to the PR linked in this issue, they are not part of bitwise libfuncs. So how should I refactor bitwise? |
did you check this PR out? https://github.com/lambdaclass/cairo_native/pull/518/files it added a file src/block_ext.rs which has a trait, BlockExt, and implements that trait for the melior Block type. so the bitwise libfunc builder should use that trait implementation function to append the operations and get the result |
So this: To something like this right?: |
Closed by #541 |
See: #518
Refactor the code implementing the libfuncs to use the trait methods from
BlockExt
.The text was updated successfully, but these errors were encountered: