-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor common operations into a block trait #518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
April 17, 2024 11:07
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
- Coverage 89.68% 89.54% -0.15%
==========================================
Files 107 108 +1
Lines 34759 34322 -437
==========================================
- Hits 31175 30733 -442
- Misses 3584 3589 +5 ☔ View full report in Codecov by Sentry. |
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
13.495 ± 0.062 | 13.404 | 13.635 | 31.03 ± 0.17 |
cairo-native (embedded AOT) |
1.568 ± 0.015 | 1.542 | 1.592 | 3.60 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.545 ± 0.017 | 1.529 | 1.578 | 3.55 ± 0.04 |
cairo-native (standalone AOT) |
0.636 ± 0.002 | 0.634 | 0.639 | 1.46 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.435 ± 0.001 | 0.434 | 0.438 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
12.981 ± 0.053 | 12.937 | 13.113 | 1597.14 ± 18.68 |
cairo-native (embedded AOT) |
1.108 ± 0.019 | 1.084 | 1.135 | 136.36 ± 2.79 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.108 ± 0.013 | 1.086 | 1.127 | 136.28 ± 2.17 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.02 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.008 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.894 ± 0.025 | 1.861 | 1.931 | 27.93 ± 0.37 |
cairo-native (embedded AOT) |
1.186 ± 0.008 | 1.177 | 1.198 | 17.48 ± 0.12 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.433 ± 0.017 | 1.417 | 1.465 | 21.13 ± 0.25 |
cairo-native (standalone AOT) |
0.112 ± 0.000 | 0.111 | 0.112 | 1.64 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.068 ± 0.000 | 0.068 | 0.068 | 1.00 |
juanbono
approved these changes
Apr 17, 2024
This was referenced Apr 18, 2024
This was referenced Apr 18, 2024
igaray
approved these changes
Apr 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 19, 2024
Can I take this? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of repeated places in codegen where we use complicated or repetitive operations, this refactors some common complexity so we can avoid mistakes.
For now I only use the methods in a few places like the array libfuncs, but it could be used in all libfuncs, It's just quite some more work to do replacing those.
Operations that are in BlockExt that can be replaced
Checklist