Update to LLVM 18 (and Rust 1.78) (#566)

* update to llvm 18 * fix clippy * fix * fix clippy * unignore felt to bool bug * unignore tests * unignore test storage_base_address_from_felt252 * fix bench script * comment sec r1 new test * fix ci * upd lockfile * update dockerfile * fix * ignore test * align to 16 on x86 * try * unwrap * fix assert * x * fix * fix get_integer_layout2 * rust 1.78 and fix array from jit * bug * Fix slice from null pointer bug. * clippy * try fix push aligned * update felt abi align * unignore test to not miss it * update runtime to use proper felt abi * evert "update runtime to use proper felt abi" This reverts commit a02993e. * fix push_aligned on x86 with 16 align * format2 * unignore self referencing test * fix get_execution_info_v2 * unignore more tests * remove old todo * uncomment code --------- Co-authored-by: Esteve Soler Arderiu <soler.arderiu@gmail.com>
lambdaclass · May 22, 2024 · 0b3fe0a · 0b3fe0a
1 parent ad8529d
commit 0b3fe0a
Show file tree

Hide file tree

Showing 52 changed files with 942 additions and 2,343 deletions.
diff --git a/.github/workflows/bench-hyperfine.yml b/.github/workflows/bench-hyperfine.yml
@@ -20,8 +20,8 @@ jobs:
     runs-on: ubuntu-latest
     env:
       CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
-      MLIR_SYS_170_PREFIX: /usr/lib/llvm-17/
-      TABLEGEN_170_PREFIX: /usr/lib/llvm-17/
+      MLIR_SYS_180_PREFIX: /usr/lib/llvm-18/
+      TABLEGEN_180_PREFIX: /usr/lib/llvm-18/
     steps:
       - uses: actions/checkout@v4
       - name: check and free hdd space left
@@ -50,11 +50,11 @@ jobs:
       - name: add llvm deb repository
         uses: myci-actions/add-deb-repo@10
         with:
-          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main
+          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
           repo-name: llvm-repo
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
-        run: sudo apt-get install llvm-17 llvm-17-dev llvm-17-runtime clang-17 clang-tools-17 lld-17 libpolly-17-dev libmlir-17-dev mlir-17-tools
+        run: sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
       - name: Install hyperfine
         uses: taiki-e/install-action@v2
         with:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,9 +12,9 @@ jobs:
     name: clippy
     runs-on: ubuntu-latest
     env:
-      MLIR_SYS_170_PREFIX: /usr/lib/llvm-17/
-      LLVM_SYS_170_PREFIX: /usr/lib/llvm-17/
-      TABLEGEN_170_PREFIX: /usr/lib/llvm-17/
+      MLIR_SYS_180_PREFIX: /usr/lib/llvm-18/
+      LLVM_SYS_180_PREFIX: /usr/lib/llvm-18/
+      TABLEGEN_180_PREFIX: /usr/lib/llvm-18/
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@1.76
@@ -24,11 +24,11 @@ jobs:
       - name: add llvm deb repository
         uses: myci-actions/add-deb-repo@10
         with:
-          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main
+          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
           repo-name: llvm-repo
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
-        run: sudo apt-get install llvm-17 llvm-17-dev llvm-17-runtime clang-17 clang-tools-17 lld-17 libpolly-17-dev libmlir-17-dev mlir-17-tools
+        run: sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
       - name: Clippy
         run: make check
 
@@ -79,9 +79,9 @@ jobs:
   udeps:
     runs-on: ubuntu-latest
     env:
-      MLIR_SYS_170_PREFIX: /usr/lib/llvm-17/
-      LLVM_SYS_170_PREFIX: /usr/lib/llvm-17/
-      TABLEGEN_170_PREFIX: /usr/lib/llvm-17/
+      MLIR_SYS_180_PREFIX: /usr/lib/llvm-18/
+      LLVM_SYS_180_PREFIX: /usr/lib/llvm-18/
+      TABLEGEN_180_PREFIX: /usr/lib/llvm-18/
       RUSTUP_TOOLCHAIN: nightly-2024-02-01  # udeps needs nightly
     steps:
       - uses: actions/checkout@v4
@@ -93,11 +93,11 @@ jobs:
       - name: add llvm deb repository
         uses: myci-actions/add-deb-repo@10
         with:
-          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main
+          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
           repo-name: llvm-repo
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
-        run: sudo apt-get install llvm-17 llvm-17-dev llvm-17-runtime clang-17 clang-tools-17 lld-17 libpolly-17-dev libmlir-17-dev mlir-17-tools
+        run: sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
       - name: "Download and run cargo-udeps"
         run: |
           wget -O - -c https://github.com/est31/cargo-udeps/releases/download/v0.1.45/cargo-udeps-v0.1.45-x86_64-unknown-linux-gnu.tar.gz | tar -xz
@@ -107,9 +107,9 @@ jobs:
     name: test (linux, amd64)
     runs-on: ubuntu-latest
     env:
-      MLIR_SYS_170_PREFIX: /usr/lib/llvm-17/
-      LLVM_SYS_170_PREFIX: /usr/lib/llvm-17/
-      TABLEGEN_170_PREFIX: /usr/lib/llvm-17/
+      MLIR_SYS_180_PREFIX: /usr/lib/llvm-18/
+      LLVM_SYS_180_PREFIX: /usr/lib/llvm-18/
+      TABLEGEN_180_PREFIX: /usr/lib/llvm-18/
       RUST_LOG: debug
     steps:
       - uses: actions/checkout@v4
@@ -139,11 +139,11 @@ jobs:
       - name: add llvm deb repository
         uses: myci-actions/add-deb-repo@10
         with:
-          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main
+          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
           repo-name: llvm-repo
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
-        run: sudo apt-get install llvm-17 llvm-17-dev llvm-17-runtime clang-17 clang-tools-17 lld-17 libpolly-17-dev libmlir-17-dev mlir-17-tools
+        run: sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
       - name: Install deps
         run: make deps
       - name: Build cairo-native-runtime library.
@@ -158,9 +158,9 @@ jobs:
     env:
       CARGO_TERM_COLOR: always
       LIBRARY_PATH: /opt/homebrew/lib
-      MLIR_SYS_170_PREFIX: /opt/homebrew/opt/llvm@17
-      LLVM_SYS_170_PREFIX: /opt/homebrew/opt/llvm@17
-      TABLEGEN_170_PREFIX: /opt/homebrew/opt/llvm@17
+      MLIR_SYS_180_PREFIX: /opt/homebrew/opt/llvm@18
+      LLVM_SYS_180_PREFIX: /opt/homebrew/opt/llvm@18
+      TABLEGEN_180_PREFIX: /opt/homebrew/opt/llvm@18
       RUST_LOG: debug
     steps:
       - uses: actions/checkout@v4
@@ -187,9 +187,9 @@ jobs:
     runs-on: ubuntu-latest
     env:
       CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
-      MLIR_SYS_170_PREFIX: /usr/lib/llvm-17/
-      LLVM_SYS_170_PREFIX: /usr/lib/llvm-17/
-      TABLEGEN_170_PREFIX: /usr/lib/llvm-17/
+      MLIR_SYS_180_PREFIX: /usr/lib/llvm-18/
+      LLVM_SYS_180_PREFIX: /usr/lib/llvm-18/
+      TABLEGEN_180_PREFIX: /usr/lib/llvm-18/
       RUST_LOG: debug
     steps:
       - uses: actions/checkout@v4
@@ -219,11 +219,11 @@ jobs:
       - name: add llvm deb repository
         uses: myci-actions/add-deb-repo@10
         with:
-          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main
+          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
           repo-name: llvm-repo
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
-        run: sudo apt-get install llvm-17 llvm-17-dev llvm-17-runtime clang-17 clang-tools-17 lld-17 libpolly-17-dev libmlir-17-dev mlir-17-tools
+        run: sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
       - name: Install cargo-llvm-cov
         uses: taiki-e/install-action@cargo-llvm-cov
       - name: Install scarb

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -13,9 +13,9 @@ jobs:
   release:
     runs-on: ubuntu-latest
     env:
-        MLIR_SYS_170_PREFIX: /usr/lib/llvm-17/
-        LLVM_SYS_170_PREFIX: /usr/lib/llvm-17/
-        TABLEGEN_170_PREFIX: /usr/lib/llvm-17/
+        MLIR_SYS_180_PREFIX: /usr/lib/llvm-18/
+        LLVM_SYS_180_PREFIX: /usr/lib/llvm-18/
+        TABLEGEN_180_PREFIX: /usr/lib/llvm-18/
         CRATES_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
     steps:
       - name: Checkout
@@ -32,11 +32,11 @@ jobs:
       - name: add llvm deb repository
         uses: myci-actions/add-deb-repo@10
         with:
-          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main
+          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
           repo-name: llvm-repo
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
-        run: sudo apt-get install llvm-17 llvm-17-dev llvm-17-runtime clang-17 clang-tools-17 lld-17 libpolly-17-dev libmlir-17-dev mlir-17-tools
+        run: sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
       - name: publish the runtime
         run: cargo publish --token ${CRATES_TOKEN} --all-features -p cairo-native-runtime
       - name: publish the crate

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -13,9 +13,9 @@ jobs:
   release:
     runs-on: ubuntu-latest
     env:
-        MLIR_SYS_170_PREFIX: /usr/lib/llvm-17/
-        LLVM_SYS_170_PREFIX: /usr/lib/llvm-17/
-        TABLEGEN_170_PREFIX: /usr/lib/llvm-17/
+        MLIR_SYS_180_PREFIX: /usr/lib/llvm-18/
+        LLVM_SYS_180_PREFIX: /usr/lib/llvm-18/
+        TABLEGEN_180_PREFIX: /usr/lib/llvm-18/
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -31,11 +31,11 @@ jobs:
       - name: add llvm deb repository
         uses: myci-actions/add-deb-repo@10
         with:
-          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main
+          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
           repo-name: llvm-repo
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
-        run: sudo apt-get install llvm-17 llvm-17-dev llvm-17-runtime clang-17 clang-tools-17 lld-17 libpolly-17-dev libmlir-17-dev mlir-17-tools
+        run: sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
       - name: build release
         run: make build
       - name: Release

diff --git a/.github/workflows/rustdoc.yml b/.github/workflows/rustdoc.yml
@@ -13,21 +13,21 @@ jobs:
     name: GitHub Pages
     runs-on: ubuntu-latest
     env:
-      MLIR_SYS_170_PREFIX: /usr/lib/llvm-17/
-      LLVM_SYS_170_PREFIX: /usr/lib/llvm-17/
-      TABLEGEN_170_PREFIX: /usr/lib/llvm-17/
+      MLIR_SYS_180_PREFIX: /usr/lib/llvm-18/
+      LLVM_SYS_180_PREFIX: /usr/lib/llvm-18/
+      TABLEGEN_180_PREFIX: /usr/lib/llvm-18/
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@1.76.0
       - uses: Swatinem/rust-cache@v2
       - name: add llvm deb repository
         uses: myci-actions/add-deb-repo@11
         with:
-          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-17 main
+          repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
           repo-name: llvm-repo
           keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
       - name: Install LLVM
-        run: sudo apt-get install llvm-17 llvm-17-dev llvm-17-runtime clang-17 clang-tools-17 lld-17 libpolly-17-dev libmlir-17-dev mlir-17-tools
+        run: sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
       - name: Build docs
         run: make doc
       - name: Deploy Documentation

diff --git a/Cargo.lock b/Cargo.lock