fix: assign validation rules in place to preserve segment-index alignment #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index alignment Fix Memory::add_validation_rule to assign in place instead of inserting, preventing Vec index shifting that misaligns validation rules with segment indices; add a unit test to verify that adding rules out of order does not shift existing entries and that validate_existing_memory applies rules to the correct segments.
Collaborator
|
Hi, @Galoretka! This PR looks good but please add the corresponding changelog entry. |
Contributor
Author
Did it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Memory::add_validation_rule to assign in place instead of inserting, preventing Vec index shifting that misaligns validation rules with segment indices; add a unit test to verify that adding rules out of order does not shift existing entries and that validate_existing_memory applies rules to the correct segments.