-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance WXPython4 compatibility in Default Profile Reversion dialog #52
Conversation
…ance WXPy4 compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures compatibility with wx Py 4. Anyway, this dialog could be improved by using guiHelper to enhance the visual appearance, according to NVDA 2016.4 and above.
Also, this could be documented in the readme.
Now guiHelper is used. Please review it again. Regards. |
I approved changes since comments are related just to style, not functionality:
Thanks |
I implemented your suggestions, so I think we can merge now. Regarding the update of the changelog I think that we can do it when preparing 1.2.2 stable, and anyway directly to master. Regards. |
By the way, thanks for your comments. I'm new to coding and any help is always appreciated. Regards. |
OK, if you need access to addonFiles to update get.php let me know. Joseph and me are admins of addonFiles repo. Or I can modify get.php, but perhaps it's better that people can write to the repo to work faster and we can do other things too. |
I think I already have write access to addonFiles. Anyway I'll check and
let you know if not.
Thanks. Regards.
|
Yes, I remember I gave access to you, but in case this was lost or something, since a person removed it and then access for people could suffer changes, and I'm not sure when this happened. |
In order to improve compatibility with WXPython 4, deprecated wx.NewId() has been changed to wx.ID_ANY on lambdaSetupProfile, as IDs are not relevant in this case.
In addition, the version in buildVars was updated from 1.2.1A to 1.2.2-dev.
If any problem please comment.