feat: Add shadcn/ui registry for medusa-forms components #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codegen-sh[bot]](https://avatars.githubusercontent.com/in/321279?s=60&v=4){kind=small}
- Add main registry.json with shadcn/ui schema - Create registry files for all UI components (input, select, checkbox, textarea, datepicker, currency-input) - Create registry files for all controlled components with react-hook-form integration - Add field-wrapper, field-error, and label base components - Include proper dependency management between components - Add comprehensive documentation in REGISTRY.md This allows developers to install medusa-forms components using: npx shadcn@latest add --registry <url> <component-name>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
|
I see a check failed - I'm on it! 🫡 |
|
✅ Fixed failing check suite in this commit. The issues were: 1. JSON Formatting Issues 🎨
2. TypeScript Configuration Errors ⚙️
The CI workflow now passes all required steps:
The PR should now pass all checks! 🚀 💻 View my work • React 👍 or 👎 |
- Add build-registry.js script that generates registry files from source components - Replace inline content with file references for better maintainability - Add build:registry script to package.json - Update REGISTRY.md with maintenance documentation - Validate source files exist before generating registry - Eliminate code duplication between source files and registry JSON This solves the maintenance issue where registry files had to be manually updated whenever component source code changed. Now the registry is automatically generated from the actual source files.
codegen-sh
bot
force-pushed
the
codegen-bot/add-shadcn-registry-1749076540
branch
from
c9ea3ad to
c70b7b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a custom shadcn/ui registry that allows developers to install medusa-forms components using the native shadcn CLI, based on the work done in lambda-curry/forms#88.
🎯 What's Added
Registry Infrastructure
Available Components
Base UI Components
field-wrapper- Core wrapper with error handling and labelsfield-error- Error display componentlabel- Label component with tooltip supportinput- Base input componentselect- Base select componentfield-checkbox- Base checkbox componenttextarea- Base textarea componentdatepicker- Base datepicker componentcurrency-input- Base currency input componentControlled Components (React Hook Form)
controlled-input- Input with react-hook-form integrationcontrolled-select- Select with react-hook-form integrationcontrolled-checkbox- Checkbox with react-hook-form integrationcontrolled-textarea- Textarea with react-hook-form integrationcontrolled-datepicker- DatePicker with react-hook-form integrationcontrolled-currency-input- CurrencyInput with react-hook-form integration🚀 Usage
Install components using the shadcn CLI:
🏗️ Architecture
📚 Documentation
Added comprehensive documentation in
REGISTRY.mdcovering:This enables developers to choose between npm package imports or CLI-based installation while maintaining the same component functionality.
💻 View my work • About Codegen