Feature InventoryCleaner module#229
Open
IceTank wants to merge 8 commits intolambda-client:1.21.11from
Open
Conversation
Contributor
Author
Auto.drop.mp4Auto.inv.drop.mp4 |
beanbag44
requested changes
Jan 26, 2026
Member
beanbag44
left a comment
beanbag44
left a comment
There was a problem hiding this comment.
Really handy module, just some small nit picks and changes
emyfops
requested changes
Jan 27, 2026
Use @WrapMethod in mixin Other nits
…re descriptions to settings
beanbag44
requested changes
Feb 23, 2026
Member
beanbag44
left a comment
beanbag44
left a comment
There was a problem hiding this comment.
when clicking an empty slot, it still throws a stack to make space
| """.trimIndent(), | ||
| tag = ModuleTag.PLAYER | ||
| ) { | ||
| private val itemsCanTrash by setting( |
Member
There was a problem hiding this comment.
settings should be written on one line each
| } | ||
|
|
||
| fun SafeContext.checkShouldTrashSomething() { | ||
| if (player.health > 0.0f && !player.isSpectator && dropToPickup && !player.isCreative) { |
Member
There was a problem hiding this comment.
could probably replace the health check for player.isAlive. I'd also just check if the players in survival
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module adds a feature to auto drop items when you don't have space in your inventory