Skip to content

Conversation

@raumonr
Copy link

@raumonr raumonr commented Jun 16, 2024

No description provided.

@codesandbox
Copy link

codesandbox bot commented Jun 16, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@laluxx
Copy link
Owner

laluxx commented Jun 17, 2024

Thank you for your pull request!
I appreciate your effort to improve the code.
However, I think the following approach might be more appropriate for handling indentation:

for (size_t i = 0; i < indentation; i++) {
    da_append(sb, ' ');
}

Could you please adjust your contribution accordingly?
Thanks again for your contribution and looking forward to your update!

@raumonr
Copy link
Author

raumonr commented Jun 19, 2024

Hi,
Thanks for helpful feedback.
I will try to help more in the future.
See you soon.

@laluxx laluxx merged commit a755197 into laluxx:master Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants