优化String.format

laijunxiong · Sep 18, 2019 · d600604 · d600604
1 parent 5e2066d
commit d600604
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 19 deletions.
diff --git a/sandbox-agent/src/main/java/com/alibaba/jvm/sandbox/agent/SandboxClassLoader.java b/sandbox-agent/src/main/java/com/alibaba/jvm/sandbox/agent/SandboxClassLoader.java
@@ -18,14 +18,14 @@
  */
 class SandboxClassLoader extends URLClassLoader {
 
-    private final String namespace;
+    private final String toString;
     private final String path;
 
     SandboxClassLoader(final String namespace,
                        final String sandboxCoreJarFilePath) throws MalformedURLException {
         super(new URL[]{new URL("file:" + sandboxCoreJarFilePath)});
-        this.namespace = namespace;
         this.path = sandboxCoreJarFilePath;
+        this.toString = String.format("SandboxClassLoader[namespace=%s;path=%s;]", namespace, path);
     }
 
     @Override
@@ -73,7 +73,7 @@ protected synchronized Class<?> loadClass(String name, boolean resolve) throws C
 
     @Override
     public String toString() {
-        return String.format("SandboxClassLoader[namespace=%s;path=%s;]", namespace, path);
+        return toString;
     }
 
 
@@ -127,7 +127,7 @@ public void closeIfPossible() {
     private <T> T forceGetDeclaredFieldValue(Class<?> clazz, String name, Object target) throws NoSuchFieldException, IllegalAccessException {
         final Field field = clazz.getDeclaredField(name);
         field.setAccessible(true);
-        return (T)field.get(target);
+        return (T) field.get(target);
     }
 
 }
diff --git a/sandbox-core/src/main/java/com/alibaba/jvm/sandbox/core/enhance/weaver/asm/EventWeaver.java b/sandbox-core/src/main/java/com/alibaba/jvm/sandbox/core/enhance/weaver/asm/EventWeaver.java
@@ -40,10 +40,10 @@ class CallAsmCodeLock extends AsmCodeLock {
  */
 class AsmTryCatchBlock {
 
-    protected final Label start;
-    protected final Label end;
-    protected final Label handler;
-    protected final String type;
+    final Label start;
+    final Label end;
+    final Label handler;
+    final String type;
 
     AsmTryCatchBlock(Label start, Label end, Label handler, String type) {
         this.start = start;
@@ -111,18 +111,10 @@ private String getBehaviorSignCode(final String name,
                                        final String desc) {
         final Type methodType = Type.getMethodType(desc);
         final Collection<String> parameterClassNameArray = new ArrayList<String>();
-        if (null != methodType.getArgumentTypes()) {
-            for (final Type parameterType : methodType.getArgumentTypes()) {
-                parameterClassNameArray.add(parameterType.getClassName());
-            }
+        for (final Type parameterType : methodType.getArgumentTypes()) {
+            parameterClassNameArray.add(parameterType.getClassName());
         }
-        final String signCode = String.format(
-                "%s#%s(%s)",
-                targetJavaClassName,
-                name,
-                join(parameterClassNameArray, ",")
-        );
-        return signCode;
+        return targetJavaClassName + "#" + name + "(" + join(parameterClassNameArray, ",") + ")";
     }
 
     @Override