fix: rename Appium Desktop -> Appium Inspector everywhere (appium#790)

* chore: rename Appium Desktop -> Appium Inspector

* chore: replace data-appium-desktop with -inspector

* chore: use more unique key for app title

.github/ISSUE_TEMPLATE.md

@@ -1,16 +1,16 @@
-## Appium or Appium Desktop?
+## Appium or Appium Inspector?
 
-You are reporting an issue at the Appium Desktop repository. Appium Desktop is a wrapper around Appium. If you are having trouble running tests, it is much more likely that the problem you are encountering is not a problem with Appium Desktop but with Appium. For that reason we require you to have tried your testcase with Appium CLI before reporting issues. Check the checkbox below to confirm that you have proven your issue does _not_ reproduce on Appium itself:
+You are reporting an issue at the Appium Inspector repository. Appium Inspector is a wrapper around Appium. If you are having trouble running tests, it is much more likely that the problem you are encountering is not a problem with Appium Inspector but with Appium. For that reason we require you to have tried your testcase with Appium CLI before reporting issues. Check the checkbox below to confirm that you have proven your issue does _not_ reproduce on Appium itself:
 
-- [ ] I have verified that my issue does not occur with Appium and should be investigated as an Appium Desktop issue
+- [ ] I have verified that my issue does not occur with Appium and should be investigated as an Appium Inspector issue
 
 ## The problem
 
 _Replace this section with a description of your issue_
 
 ## Environment
 
-- I am running Appium Desktop version _<insert version here>_.
+- I am running Appium Inspector version _<insert version here>_.
 - I am on (pick one):
     - [ ] Mac
     - [ ] Windows

.gitignore

@@ -16,4 +16,3 @@ Certificates.p12
 .history
 junit-test-results.xml
 junit-testresults.xml
-appium-desktop

app/main/auto-updater/update-checker.js

@@ -49,7 +49,7 @@ export function setUpAutoUpdater ({
 
       let detail = i18n.t('updateDetails', {pubDate, notes: notes.replace('*', '\n*')});
       if (env.NO_AUTO_UPDATE) {
-        detail += `\n\nhttps://www.github.com/appium/appium-desktop/releases/latest`;
+        detail += `\n\nhttps://www.github.com/appium/appium-inspector/releases/latest`;
       }
 
 
@@ -99,7 +99,7 @@ export function setUpAutoUpdater ({
       type: 'info',
       buttons: [i18n.t('OK')],
       message: i18n.t('No update available'),
-      detail: i18n.t('Appium Desktop is up-to-date'),
+      detail: i18n.t('Appium Inspector is up-to-date'),
     });
   });
 

app/main/menus.js

@@ -19,7 +19,7 @@ function languageMenu () {
 function getShowAppInfoClickAction () {
   return () => {
     dialog.showMessageBox({
-      title: i18n.t('appiumDesktop'),
+      title: i18n.t('appiumInspector'),
       message: i18n.t('showAppInfo', {
         appVersion: app.getVersion(),
         electronVersion: process.versions.electron,
@@ -168,7 +168,7 @@ function macMenuHelp () {
     }, {
       label: i18n.t('Search Issues'),
       click () {
-        shell.openExternal('https://github.com/appium/appium-desktop/issues');
+        shell.openExternal('https://github.com/appium/appium-inspector/issues');
       }
     }, {
       label: i18n.t('Add Or Improve Translations'),
@@ -340,7 +340,7 @@ function otherMenuHelp () {
     }, {
       label: i18n.t('Search Issues'),
       click () {
-        shell.openExternal('https://github.com/appium/appium-desktop/issues');
+        shell.openExternal('https://github.com/appium/appium-inspector/issues');
       }
     }, {
       label: i18n.t('Add Or Improve Translations'),

app/renderer/components/ErrorBoundary/ErrorBoundary.js

@@ -3,7 +3,7 @@ import { Alert } from 'antd';
 import styles from './ErrorBoundary.css';
 import { ALERT } from '../AntdTypes';
 
-const CREATE_ISSUE_URL = 'https://github.com/appium/appium-desktop/issues/new';
+const CREATE_ISSUE_URL = 'https://github.com/appium/appium-inspector/issues/new';
 
 export default class ErrorBoundary extends React.Component {
   constructor (props) {

app/renderer/lib/webview-helpers.js

@@ -54,10 +54,10 @@ export function setHtmlElementAttributes (obj) {
   Array.from(htmlElements).forEach((el) => {
     const rect = el.getBoundingClientRect();
 
-    el.setAttribute('data-appium-desktop-width', Math.round(rect.width * dpr));
-    el.setAttribute('data-appium-desktop-height', Math.round(rect.height * dpr));
-    el.setAttribute('data-appium-desktop-x', Math.round(rect.left * dpr));
-    el.setAttribute('data-appium-desktop-y', Math.round(webviewStatusAddressBarHeight + (rect.top * dpr)));
+    el.setAttribute('data-appium-inspector-width', Math.round(rect.width * dpr));
+    el.setAttribute('data-appium-inspector-height', Math.round(rect.height * dpr));
+    el.setAttribute('data-appium-inspector-x', Math.round(rect.left * dpr));
+    el.setAttribute('data-appium-inspector-y', Math.round(webviewStatusAddressBarHeight + (rect.top * dpr)));
   });
 }
 
@@ -92,16 +92,16 @@ export function parseSource (source) {
     .removeAttr('height')
     .removeAttr('x')
     .removeAttr('y')
-    // remove all `data-appium-desktop-` prefixes so only the width|height|x|y are there
+    // remove all `data-appium-inspector-` prefixes so only the width|height|x|y are there
     .each(function () {
       const $el = $(this);
 
       ['width', 'height', 'x', 'y'].forEach((rectAttr) => {
-        if ($el.attr(`data-appium-desktop-${rectAttr}`)) {
-          $el.attr(rectAttr, $el.attr(`data-appium-desktop-${rectAttr}`));
+        if ($el.attr(`data-appium-inspector-${rectAttr}`)) {
+          $el.attr(rectAttr, $el.attr(`data-appium-inspector-${rectAttr}`));
 
           /* remove the old attribute */
-          $el.removeAttr(`data-appium-desktop-${rectAttr}`);
+          $el.removeAttr(`data-appium-inspector-${rectAttr}`);
         }
       });
     });

assets/locales/de/translation.json

@@ -12,7 +12,7 @@
   "te": "Telugu",
   "pt-BR": "Português (Brasil)",
   "it": "Italiano",
-  "appiumDesktop": "Appium Desktop",
+  "appiumInspector": "Appium Inspector",
   "Edit": "Bearbeiten",
   "Redo": "Wiederholen",
   "Cut": "Ausschneiden",
@@ -88,16 +88,16 @@
   "presetAdded": "Your preset '{{presetName}}' has been added to the list in the Presets tab!",
   "datetimeFormat": "D.M.YYYY, HH:mm",
   "updateDetails": "Release Date: {{pubDate}}\n\nRelease Notes: {{notes}}",
-  "appiumIsAvailable": "Appium Desktop {{name}} ist verfügbar",
+  "appiumIsAvailable": "Appium Inspector {{name}} ist verfügbar",
   "updateIsBeingDownloaded": "Update is being downloaded now. You will be notified again when it is complete",
-  "updateIsDownloaded": "Appium Desktop {{releaseName}} has been downloaded. Must restart to apply the updates (note: it may take several minutes for Appium Desktop to install and restart)",
+  "updateIsDownloaded": "Appium Inspector {{releaseName}} has been downloaded. Must restart to apply the updates (note: it may take several minutes for Appium Inspector to install and restart)",
   "updateDownloadFailed": "Failed to download update. Reason: {{message}}",
   "OK": "OK",
   "Install Now": "Jetzt installieren",
   "Install Later": "Später installieren",
   "Update Download Started": "Update Download Started",
   "No update available": "Keine Aktualisierungen verfügbar",
-  "Appium Desktop is up-to-date": "Appium Desktop ist auf dem aktuellen Stand",
+  "Appium Inspector is up-to-date": "Appium Inspector ist auf dem aktuellen Stand",
   "Later": "Später",
   "Update Downloaded": "Das Update wurde heruntergeladen",
   "Could not download update": "Das Update konnte nicht heruntergeladen werden",
@@ -133,7 +133,6 @@
   "The server is stopped": "Der Server ist gestoppt",
   "The server is waiting for all connections to close": "The server is waiting for all connections to close",
   "badStatus": "Ungültiger Status: {{serverStatus}}",
-  "Appium Desktop should be run from the Applications folder": "Appium Desktop should be run from the Applications folder",
   "Move to Applications Folder": "Move to Applications Folder",
   "locatorStrategy": "Locator-Strategie:",
   "selector": "Selektor:",
@@ -180,7 +179,7 @@
   "Interactions are not available for this element": "Interactions are not available for this element",
   "usingXPathNotRecommended": "Using XPath locators is not recommended and can lead to fragile tests. Ask your development team to provide unique accessibility locators instead!",
   "usingSwitchContextRecommended": "Webview context(s) detected; certain elements might only be accessible after switching to a webview context, which must be done in an Appium script. See http://appium.io/docs/en/writing-running-appium/web/hybrid/ for more information",
-  "usingWebviewContext": "Using the Webview inspector in Appium Desktop is less accurate in retrieving and selecting DOM elements in comparison to using the DevTools of Chrome and Safari.",
+  "usingWebviewContext": "Using the Webview inspector in Appium Inspector is less accurate in retrieving and selecting DOM elements in comparison to using the DevTools of Chrome and Safari.",
   "contextSwitcher": "You can switch to a different context here. See http://appium.io/docs/en/writing-running-appium/web/hybrid/ for more information",
   "Tap": "Tippen",
   "Gathering initial app source…": "Die Anfangsquelle des Programms wird gesammelt…",
@@ -202,7 +201,7 @@
   "SauceLabs Data Center": "SauceLabs Data Center",
   "US": "US",
   "EU": "EU",
-  "UP": "Appium Desktop will use the new Sauce Labs Unified Platform US endpoint by default. If you want to use the old US endpoint then do the following: Go to the 'Custom server'-tab, add 'ondemand.saucelabs.com' as a remote host, use port '433', the remote path is '/wd/hub' and last but not least enable 'SSL'.",
+  "UP": "Appium Inspector will use the new Sauce Labs Unified Platform US endpoint by default. If you want to use the old US endpoint then do the following: Go to the 'Custom server'-tab, add 'ondemand.saucelabs.com' as a remote host, use port '433', the remote path is '/wd/hub' and last but not least enable 'SSL'.",
   "proxyThroughSC": "Proxy through Sauce Connect's Selenium Relay",
   "SSL": "SSL",
   "text": "Text",
@@ -248,7 +247,7 @@
   "LambdaTest Username": "LambdaTest Username",
   "LambdaTest Access Key": "LambdaTest Access Key",
   "Bitbar API Key": "Bitbar API Key",
-  "willUseCurrentlyRunningServer": "Will use currently-running Appium Desktop server",
+  "willUseCurrentlyRunningServer": "Will use currently-running Appium Inspector server",
   "Name": "Name",
   "enterYourSessionId": "Enter your session ID here",
   "Proxy URL": "Proxy-URL",

assets/locales/en/translation.json

@@ -12,7 +12,7 @@
   "te": "Telugu",
   "pt-BR": "Portuguese (Brazil)",
   "it":"Italiano",
-  "appiumDesktop": "Appium Desktop",
+  "appiumInspector": "Appium Inspector",
   "Edit": "Edit",
   "Redo": "Redo",
   "Cut": "Cut",
@@ -88,16 +88,16 @@
   "presetAdded": "Your preset '{{presetName}}' has been added to the list in the Presets tab!",
   "datetimeFormat": "MMM Do YYYY, h:mma",
   "updateDetails": "Release Date: {{pubDate}}\n\nRelease Notes: {{notes}}",
-  "appiumIsAvailable": "Appium Desktop {{name}} is available",
+  "appiumIsAvailable": "Appium Inspector {{name}} is available",
   "updateIsBeingDownloaded": "Update is being downloaded now. You will be notified again when it is complete",
-  "updateIsDownloaded": "Appium Desktop {{releaseName}} has been downloaded. Must restart to apply the updates (note: it may take several minutes for Appium Desktop to install and restart)",
+  "updateIsDownloaded": "Appium Inspector {{releaseName}} has been downloaded. Must restart to apply the updates (note: it may take several minutes for Appium Inspector to install and restart)",
   "updateDownloadFailed": "Failed to download update. Reason: {{message}}",
   "OK": "OK",
   "Install Now": "Install Now",
   "Install Later": "Install Later",
   "Update Download Started": "Update Download Started",
   "No update available": "No update available",
-  "Appium Desktop is up-to-date": "Appium Desktop is up-to-date",
+  "Appium Inspector is up-to-date": "Appium Inspector is up-to-date",
   "Later": "Later",
   "Update Downloaded": "Update Downloaded",
   "Could not download update": "Could not download update",
@@ -133,7 +133,6 @@
   "The server is stopped": "The server is stopped",
   "The server is waiting for all connections to close": "The server is waiting for all connections to close",
   "badStatus": "Bad status: {{serverStatus}}",
-  "Appium Desktop should be run from the Applications folder": "Appium Desktop should be run from the Applications folder",
   "Move to Applications Folder": "Move to Applications Folder",
   "locatorStrategy": "Locator Strategy:",
   "selector": "Selector:",
@@ -180,7 +179,7 @@
   "Interactions are not available for this element": "Interactions are not available for this element",
   "usingXPathNotRecommended": "Using XPath locators is not recommended and can lead to fragile tests. Ask your development team to provide unique accessibility locators instead!",
   "usingSwitchContextRecommended": "Webview context(s) detected; certain elements might only be accessible after switching to a webview context, which must be done in an Appium script. See http://appium.io/docs/en/writing-running-appium/web/hybrid/ for more information",
-  "usingWebviewContext": "Using the Webview inspector in Appium Desktop is less accurate in retrieving and selecting DOM elements in comparison to using the DevTools of Chrome and Safari.",
+  "usingWebviewContext": "Using the Webview inspector in Appium Inspector is less accurate in retrieving and selecting DOM elements in comparison to using the DevTools of Chrome and Safari.",
   "contextSwitcher": "You can switch to a different context here. See http://appium.io/docs/en/writing-running-appium/web/hybrid/ for more information",
   "Tap": "Tap",
   "Gathering initial app source…": "Gathering initial app source…",
@@ -202,7 +201,7 @@
   "SauceLabs Data Center": "SauceLabs Data Center",
   "US": "US",
   "EU": "EU",
-  "UP": "Appium Desktop will use the new Sauce Labs Unified Platform US endpoint by default. If you want to use the old US endpoint then do the following: Go to the 'Custom server'-tab, add 'ondemand.saucelabs.com' as a remote host, use port '433', the remote path is '/wd/hub' and last but not least enable 'SSL'.",
+  "UP": "Appium Inspector will use the new Sauce Labs Unified Platform US endpoint by default. If you want to use the old US endpoint then do the following: Go to the 'Custom server'-tab, add 'ondemand.saucelabs.com' as a remote host, use port '433', the remote path is '/wd/hub' and last but not least enable 'SSL'.",
   "proxyThroughSC": "Proxy through Sauce Connect's Selenium Relay",
   "SSL": "SSL",
   "text": "text",
@@ -248,7 +247,7 @@
   "LambdaTest Username": "LambdaTest Username",
   "LambdaTest Access Key": "LambdaTest Access Key",
   "Bitbar API Key": "Bitbar API Key",
-  "willUseCurrentlyRunningServer": "Will use currently-running Appium Desktop server",
+  "willUseCurrentlyRunningServer": "Will use currently-running Appium Inspector server",
   "Name": "Name",
   "enterYourSessionId": "Enter your session ID here",
   "Proxy URL": "Proxy URL",

assets/locales/es-ES/translation.json

@@ -12,7 +12,7 @@
   "te": "Télugu",
   "pt-BR": "Português (Brasil)",
   "it": "Español",
-  "appiumDesktop": "Appium Desktop",
+  "appiumInspector": "Appium Inspector",
   "Edit": "Editar",
   "Redo": "Rehacer",
   "Cut": "Cortar",
@@ -88,16 +88,16 @@
   "presetAdded": "¡Tu predefinido '{{presetName}}' ha sido añadido a la lista en la pestaña Predefinidos!",
   "datetimeFormat": "MMM Do YYYYY, h:mma",
   "updateDetails": "Fecha de lanzamiento: {{pubDate}}\n\nnotas: {{notes}}",
-  "appiumIsAvailable": "Appium Desktop {{name}} está disponible",
+  "appiumIsAvailable": "Appium Inspector {{name}} está disponible",
   "updateIsBeingDownloaded": "La actualización está siendo descargada ahora. Se le notificará de nuevo cuando esté completa",
-  "updateIsDownloaded": "Se ha descargado el Appium Desktop {{releaseName}}. Debe reiniciar para aplicar las actualizaciones (nota: puede tardar varios minutos para que Appium Desktop instale y reinicie)",
+  "updateIsDownloaded": "Se ha descargado el Appium Inspector {{releaseName}}. Debe reiniciar para aplicar las actualizaciones (nota: puede tardar varios minutos para que Appium Inspector instale y reinicie)",
   "updateDownloadFailed": "Error al descargar la actualización. Razón: {{message}}",
   "OK": "OK",
   "Install Now": "Instalar ahora",
   "Install Later": "Instalar más tarde",
   "Update Download Started": "Actualización descargando",
   "No update available": "No hay actualizaciones disponibles",
-  "Appium Desktop is up-to-date": "Appium Desktop está actualizado",
+  "Appium Inspector is up-to-date": "Appium Inspector está actualizado",
   "Later": "Más tarde",
   "Update Downloaded": "Actualización descargada",
   "Could not download update": "No se pudo descargar la actualización",
@@ -133,7 +133,6 @@
   "The server is stopped": "El servidor está detenido",
   "The server is waiting for all connections to close": "El servidor está esperando todas las conexiones para cerrar",
   "badStatus": "Estado erróneo: {{serverStatus}}",
-  "Appium Desktop should be run from the Applications folder": "Appium Desktop debe ejecutarse desde la carpeta Aplicaciones",
   "Move to Applications Folder": "Arrastrar a la carpeta Aplicaciones",
   "locatorStrategy": "Estrategia de localizador:",
   "selector": "Selector:",
@@ -180,7 +179,7 @@
   "Interactions are not available for this element": "Las interacciones no están disponibles para este elemento",
   "usingXPathNotRecommended": "El uso de los localizadores XPath no es recomendado y puede llevar a pruebas frágiles. ¡Pide a tu equipo de desarrollo que proporcione a los localizadores de accesibilidad únicos en su lugar!",
   "usingSwitchContextRecommended": "Contexto(s) de vista web detectados; ciertos elementos sólo pueden ser accesibles después de cambiar al contexto de una vista web, que debe hacerse en un script de Appium. Ver http://appium.io/docs/es/writing-running-appium/web/hybrid/ para más información",
-  "usingWebviewContext": "Using the Webview inspector in Appium Desktop is less accurate in retrieving and selecting DOM elements in comparison to using the DevTools of Chrome and Safari.",
+  "usingWebviewContext": "Using the Webview inspector in Appium Inspector is less accurate in retrieving and selecting DOM elements in comparison to using the DevTools of Chrome and Safari.",
   "contextSwitcher": "You can switch to a different context here. See http://appium.io/docs/en/writing-running-appium/web/hybrid/ for more information",
   "Tap": "Tap",
   "Gathering initial app source…": "Recolectando código fuente inicial de la aplicación…",
@@ -202,7 +201,7 @@
   "SauceLabs Data Center": "Centro de datos de SauceLabs",
   "US": "EE. UU.",
   "EU": "UE",
-  "UP": "Appium Desktop will use the new Sauce Labs Unified Platform US endpoint by default. If you want to use the old US endpoint then do the following: Go to the 'Custom server'-tab, add 'ondemand.saucelabs.com' as a remote host, use port '433', the remote path is '/wd/hub' and last but not least enable 'SSL'.",
+  "UP": "Appium Inspector will use the new Sauce Labs Unified Platform US endpoint by default. If you want to use the old US endpoint then do the following: Go to the 'Custom server'-tab, add 'ondemand.saucelabs.com' as a remote host, use port '433', the remote path is '/wd/hub' and last but not least enable 'SSL'.",
   "proxyThroughSC": "Proxy through Sauce Connect's Selenium Relay",
   "SSL": "SSL",
   "text": "texto",
@@ -248,7 +247,7 @@
   "LambdaTest Username": "LambdaTest Username",
   "LambdaTest Access Key": "LambdaTest Access Key",
   "Bitbar API Key": "Clave de la API de Bitbar",
-  "willUseCurrentlyRunningServer": "Utilizará el servidor de Appium Desktop en ejecución",
+  "willUseCurrentlyRunningServer": "Utilizará el servidor de Appium Inspector en ejecución",
   "Name": "Nombre",
   "enterYourSessionId": "Introduce tu ID de sesión aquí",
   "Proxy URL": "URL del proxy",