Double window controls in some CSD applications

[lah7]

Bug Description

gnome-disk-utility 40.0 shows double window controls: the actual window controls and a duplicate within the application. There is also a black border on the right/bottom.

The latest gtk3-classic against the older 3.38.2 does not inhibit the problem, so the GNOME developers made a change in their code.

Thankfully, it is still a GTK3 application and not GTK4, despite the versioning.

Expected Behaviour

The window controls inside the application should be hidden.

Workaround

Downgrade and pin the older version.

Screenshots

40.0

3.38.2

Environment

• OS: EndeavourOS
• Desktop Environment: KDE
• gtk3-classic Version: 3.24.27

[lah7]

Likewise, simple-scan 40.0 inhibits the same problem: double controls, and black border.

40.0

3.38.5

[MR-Diamond]

Also gnome-calculator 40.0

[wb9688]

My guess would be that those are the apps using libhandy's HdyWindow and HdyHeaderBar and that that causes this behavior.

[ZaWertun]

Just fixed similar bug in my fork of gtk3-nocsd: https://github.com/ZaWertun/gtk3-nocsd/tree/test/libhandy.
Some screenshots:

[simifor]

I looked at @ZaWertun's last commit, then browsed a bit gtk's tree to see where it'd and made a patch
patch.txt full credits to zawertun really. This only fixes the black outlines seen in some places, as I didn't even touch the CSD related commits.

[lah7]

Thank you @simifor, your patch.txt made it very easy to incorporate into the quilt patch system. Committed as 12f90e2

Thank you to @ZaWertun as well. I'm a bit lost on which commits to incorporate by looking at gtk3-nocsd's repository. Any help is much appreciated if anyone wishes to create a patch for this repository to fix this regression. I get confused with quilt too. 😅

[N0rbert]

Great! Thanks for merging.
I think, we need to skip/disable both csd__clean-headerbar.patch and csd__disabled-by-default.patch temporarily for Ubuntu MATE 21.10 impish deb-packages to get GNOME native apps look better here, so without double borders.

[lah7]

I noticed CSD applications under patched Ubuntu 21.10 doesn't look great, depending on the theme:

For Ubuntu 21.10 users, I will revert those patches in the packaging since they ship newer (40.x) GNOME apps. Just until the "new" CSD is fixed, pull requests much appreciated!

Edit: In 22.04, this returns to using the default patchset, so double controls are expected.