Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #14

Merged
merged 1 commit into from
Sep 22, 2021
Merged

fix typo #14

merged 1 commit into from
Sep 22, 2021

Conversation

pwang7
Copy link
Contributor

@pwang7 pwang7 commented Sep 14, 2021

No description provided.

@laforest
Copy link
Owner

Thank you for spotting the documentation typo.

However, I don't agree with renaming the Register inside the Register_Toggle module.
Sometimes there is no further information to carry with a module instance name, and here the Register_Toggle module itself denotes what the Register is for.

Could you please undo that last change, and I can accept the pull request.

@pwang7
Copy link
Contributor Author

pwang7 commented Sep 16, 2021

Thank you for spotting the documentation typo.

However, I don't agree with renaming the Register inside the Register_Toggle module.
Sometimes there is no further information to carry with a module instance name, and here the Register_Toggle module itself denotes what the Register is for.

Could you please undo that last change, and I can accept the pull request.

Done.

Just spot more typo, ADDR_WIDTH**2 -> 2**ADDR_WIDTH.

@laforest laforest merged commit 3a27a46 into laforest:master Sep 22, 2021
@laforest
Copy link
Owner

Thank you!

@pwang7
Copy link
Contributor Author

pwang7 commented Sep 23, 2021

BTW, will you continue writing this book?
Your book is very helpful~

@laforest
Copy link
Owner

Oh yes. I've been busy with other parts of the book for a while. I have an update going out soon.
I'm glad you are finding it helpful. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants