Skip to content

Conversation

@chenkianwee
Copy link
Contributor

Fix the issue when rel_indices tuple only has a single element the sql statement throws an error. This is resolved by removing the trailing comma from the query.

Fix the issue when rel_indices tuple only has a single element the sql statement throws an error. This is resolved by removing the trailing comma from the query.
Update data_collections_by_output_name_run_period sql.py
@CLAassistant
Copy link

CLAassistant commented Jan 6, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@chriswmackey chriswmackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chenkianwee .

What you said makes sense and this change should not break anything so I am happy to merge it.

Is there a discourse forum topic connected to this fix here or is it just an issue that you found on your own? I ask mainly to know if there are other people who need to be alerted about the fix and if you would like to do the honors.

@chriswmackey chriswmackey merged commit 9a1aa47 into ladybug-tools:master Jan 6, 2026
9 checks passed
@chenkianwee
Copy link
Contributor Author

Hi @chriswmackey ,
It is an issue I found on my own.
Happy to contribute to the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants