Skip to content

Conversation

@joshwarren
Copy link

Add update_definition endpoint, with corresponding update pipeline definition utility function.

@joshwarren joshwarren marked this pull request as ready for review September 16, 2025 12:48
@ladparth
Copy link
Owner

ladparth commented Oct 7, 2025

Thanks @joshwarren for the PR. I found one issue, Can you fix it before i merge it to dev?

The folderId should only be added to the payload when a folder is provided in create_item method. Currently it's always added even when folder is None, which will cause resolve_folder(None) to be called unnecessarily. Please update to:

if folder is not None:
    payload["folderId"] = resolve_folder(folder)

@joshwarren
Copy link
Author

Sorry for the slow response and I've also realised I've been pushing from 2 different accounts. PR is now updated as per your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants