Skip to content

Bump formidable version to ^3.5.4 #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump formidable version to ^3.5.4 #1832

wants to merge 1 commit into from
+1 −1

Conversation

mureinik
Copy link

@mureinik mureinik commented Apr 20, 2025 •
edited
Loading

Although it doesn't explicitly state it, fomidable@3.5.3 uses os.machine that was introduced in Node.js 18.9.0 (and then backported to 16.18.0).

formidable@3.5.4 fixes this issue, so in most cases this problem would go undetected. However, there's still a chance a project that uses superagent or one of its dependencies explicitly requires formidable@3.5.3, and would thus break under older Node.js versions.
Bumping the requirement to formidable@^3.5.4 solve this potential issue.

Fixes #1831

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@mureinik mureinik force-pushed the formidble-3.5.2 branch 2 times, most recently from cdf7b16 to 9e5ce96 Compare April 23, 2025 09:45
@mureinik mureinik changed the title Lock down formidable version to 3.5.2 Bump formidable version to ^3.5.4 Apr 23, 2025
@mureinik mureinik mentioned this pull request Apr 23, 2025
Open
3 tasks
@mureinik @bd-allon
fix: Bump formidable version to ^3.5.4
5feb4c9 
Although it doesn't explicitly state it, fomidable@3.5.3 uses os.machine
(https://nodejs.org/api/os.html#osmachine) that was introduced in Node.js 18.9.0
(and then backported to 16.18.0).

Since superagent should support Node.js 14.18.0 and above, it cannot use this
new version of formidable. Bumping the requirement to ^3.5.4 solves this issue.

Fixes ladjs#1831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] npm build fails with Node.js versions that don't provide os.machine
1 participant
@mureinik