Fixes #111: Fix caching issues while with tests #112

santiagobasulto · 2015-03-10T11:42:52Z

No description provided.

…svg badges ot Readme

…aded dependencies, Finished user controller, Fixed method override with querystring for ?_method=VERB, Fixed layout view path and rendering with extends

… template generators, Added pagination with express-paginate

Document gulp build ladjs#100

Fix copy errors

Update Readme.md

Closes ladjs#90: add tests for API endpoints (already started, just needs finished) Closes ladjs#98: Object #<IncomingMessage> has no method 'flash' Upgrades igloo to 0.0.6 Updates version to 0.2.24

…n-watch Adds nodemon to `gulp watch`, & API tests

Adding jade reload to gulp watch, 0.2.25

- environment-specific db names; - random session secret and cookieParser (via chance.js); - enabled autoprefixer for less middleware;

it's useful in case of using `gulp watch`, if you want to get working sourcemaps current version of less-middleware has a few issues with sourcemaps

- add autoprefixer-core dependency for less-middleware

We usually use `nodemon app` for running application on dev server, so it causes liveReload connection error. That's why I moved it to local.js.

Some improvements

Added link to the wiki

…framework, beyond the user app generated

BrunoBernardino · 2015-03-10T11:57:08Z

app/utils/caching.js

+exports = module.exports = function(IoC) {
+  return {
+    getCachingHeadersFromSettings: function(settings){
+      var maxAge = parseInt(settings.staticServer.maxAge);


Please add the parseInt()'s second argument. var maxAge = parseInt(settings.staticServer.maxAge, 10);

BrunoBernardino · 2015-03-10T12:22:26Z

Great PR! Thanks.

Apart from my comments, to improve the code to match the style guide:

You're using double quotes (") when single ' can be used
You're doing a lot of ){ when there should be a space, like ) { (in ifs, functions, etc.)

coveralls · 2015-03-10T20:19:32Z

Coverage increased (+1.83%) to 56.0% when pulling 379e203 on santiagobasulto:fix-caching-bugs-with-tests into 255da93 on niftylettuce:master.

santiagobasulto · 2015-03-16T19:16:57Z

This reminds me the days of Java with the different conventions about leaving the bracket up or down. People went crazy about that. So funny.

coveralls · 2015-03-16T19:31:29Z

Coverage increased (+1.83%) to 56.0% when pulling 118f273 on santiagobasulto:fix-caching-bugs-with-tests into 255da93 on niftylettuce:master.

niftylettuce and others added 30 commits June 6, 2014 04:14

fresh commit

20d3da5

fixes ladjs#24 with path.resolve

940185d

Release 0.0.9

cf84529

Release 0.0.8-patch

c381772

removed test folder

8183299

Release 0.0.9

c67632a

Release 0.0.9-rc.1

b2bbd22

added travis-ci, added mocha, added basic test with supertest, added …

8c7ffc0

…svg badges ot Readme

fixed igloo version

e274261

added hipchat notifications to travis-ci

207da8f

added redis-server and mongodb services to travis-ci

286f3cd

upgraded deps, removed readme badge banner, added note about tests

c5efc3f

Release 0.0.9-rc.2

25b9dd2

Re-ordered initializers (sessions need to come before csrf etc), Upgr…

34c8608

…aded dependencies, Finished user controller, Fixed method override with querystring for ?_method=VERB, Fixed layout view path and rendering with extends

added cookie-parser

3948175

Added express-paginate and implemented

751e1f1

Added MVC commands to CLI, Added templates, Integrated _.template for…

f0e3f27

… template generators, Added pagination with express-paginate

Fixed NODE_ENV for travis

6c4c74d

Release 0.0.9-rc.4

f4fdc7f

Fixed path.resolve

da80c16

Release 0.0.9-rc.6

d35bde6

Release 0.0.9-rc.7

ea88f40

Release 0.0.9-rc.8

11ff97b

Fixing config

d38f39e

removed mongoose versioning since disabled with igloo

bae3e5e

Added Winston HipChat

576ac0e

Fixed typo

d287022

Release 0.0.9-rc.10

7dab81c

Release 0.0.9-rc.11

ee8f193

Update Readme.md

8fc1380

@oitozero and others added 20 commits December 23, 2014 16:17

Update Readme.md

961a81f

Document gulp build ladjs#100

Update Readme.md

40a54b6

Fix copy errors

Merge pull request ladjs#102 from oitozero/master

e5e0973

Update Readme.md

Adds nodemon to gulp watch, & API tests

da1b31f

Closes ladjs#90: add tests for API endpoints (already started, just needs finished) Closes ladjs#98: Object #<IncomingMessage> has no method 'flash' Upgrades igloo to 0.0.6 Updates version to 0.2.24

Merge pull request ladjs#104 from niftylettuce/feature/gulp-nodemon-i…

4f3e1b4

…n-watch Adds nodemon to `gulp watch`, & API tests

Adding jade reload to gulp watch

1df2afb

Increasing version to 0.2.25

3929827

Merge pull request ladjs#105 from niftylettuce/hotfix/watch-jade

e292445

Adding jade reload to gulp watch, 0.2.25

disable robots/googlebot indexing for non-prod envs

62222d2

add gulp-autoprefixer

31534f0

generate boot/config.js with:

e197ea6

- environment-specific db names; - random session secret and cookieParser (via chance.js); - enabled autoprefixer for less middleware;

update .gitignore

e8d98c4

add option to disable less middleware for dev environment by default

c62aa69

it's useful in case of using `gulp watch`, if you want to get working sourcemaps current version of less-middleware has a few issues with sourcemaps

update package.json for config

9e89b83

- add autoprefixer-core dependency for less-middleware

move liveReload to local.js config

4f53475

We usually use `nodemon app` for running application on dev server, so it causes liveReload connection error. That's why I moved it to local.js.

remove a typo

349d0f2

Merge pull request ladjs#107 from anotheri/feature/some-improvements

b08504c

Some improvements

Added link to the wiki

327edc5

Merge pull request ladjs#108 from niftylettuce/feature/wiki-link

7a2f166

Added link to the wiki

Fixes ladjs#111: Fix caching issues while adding tests to the Eskimo …

379e203

…framework, beyond the user app generated

BrunoBernardino reviewed Mar 10, 2015
View reviewed changes

Fixed issues pointed out by Bruno

118f273

niftylettuce closed this May 10, 2016

niftylettuce force-pushed the master branch from d0f0a37 to d39b578 Compare May 10, 2016 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #111: Fix caching issues while with tests #112

Fixes #111: Fix caching issues while with tests #112

santiagobasulto commented Mar 10, 2015

BrunoBernardino Mar 10, 2015

BrunoBernardino commented Mar 10, 2015

coveralls commented Mar 10, 2015

santiagobasulto commented Mar 16, 2015

coveralls commented Mar 16, 2015

Fixes #111: Fix caching issues while with tests #112

Fixes #111: Fix caching issues while with tests #112

Conversation

santiagobasulto commented Mar 10, 2015

BrunoBernardino Mar 10, 2015

Choose a reason for hiding this comment

BrunoBernardino commented Mar 10, 2015

coveralls commented Mar 10, 2015

santiagobasulto commented Mar 16, 2015

coveralls commented Mar 16, 2015