Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bourbon-path broken with 4.2.6 and Grunt. #27

Closed
coreequip opened this issue Mar 18, 2016 · 12 comments
Closed

Bourbon-path broken with 4.2.6 and Grunt. #27

coreequip opened this issue Mar 18, 2016 · 12 comments

Comments

@coreequip
Copy link
Contributor

The Bourbon-package changes the way of exporting the path-information. Following code solved the problems on my side:

var path = require('path');
var bourbon = require('bourbon');

module.exports = {

  includePaths: [bourbon.includePaths],

  with: function() {
    var paths  = Array.prototype.slice.call(arguments);
    return [].concat.apply([bourbon.includePaths], paths);
  }

};
@pl7y
Copy link

pl7y commented Mar 19, 2016

Even for me bourbon paths are broken: include path is node_modules/bourbon, but it works only if I manually adjust it like node_modules/bourbon/app/assets/stylesheets (so that I can do import 'bourbon'in scss).
Probably related to #28 .

@pl7y
Copy link

pl7y commented Mar 19, 2016

Don't know really, but it looks like it's related to this bourbon commit.

@coreequip
Copy link
Contributor Author

Hi Andrea,

the bourbon-people uses now a standard pattern to "export" a property (here the includePaths).

What happened:
node-burbon referred to bourbon-v4.2.3 which doesn't use this pattern so they had to "resolve" the package path and uses this as include path. Works well until this happened:

This commit just increases the bourbon-version to 4.2.6. But in 4.2.4 they changed a lot. Btw: I wonder why the tests don't break.

@pl7y
Copy link

pl7y commented Mar 19, 2016

Thanks for the prompt reply!
Good observation with the tests, they should definitely fail.

@pl7y
Copy link

pl7y commented Mar 19, 2016

Hi @coreequip, I just tested your solution above and it works.

@pl7y
Copy link

pl7y commented Mar 19, 2016

@coreequip, would you contribute to the repo with the change?

@coreequip
Copy link
Contributor Author

Yes. I'll send later a pullrequest.

Done. See #29

@coreequip
Copy link
Contributor Author

See my changes, thats the reason why the tests didn't fail. But its fixed now. :-)

@pl7y
Copy link

pl7y commented Mar 19, 2016

I confirm your pull request is working! Thanks!

iamlacroix added a commit that referenced this issue Mar 19, 2016
Fixed tests and compatibility with bourbon. See issue #27
@iamlacroix
Copy link
Member

I've just published v4.2.7 to npm, let me know if that works. Thanks again for your PR! If the latest release is working, I'll go ahead and close this.

@pl7y
Copy link

pl7y commented Mar 19, 2016

For me, it works. Thanks!

@iamlacroix
Copy link
Member

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants