fix: use Reflect.getOwnPropertyDescriptor instead of Object.hasOwn

nodejs/node#52720
lachrist · Apr 27, 2024 · bae26c3 · bae26c3
1 parent 4d0b8da
commit bae26c3
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 12 deletions.
diff --git a/lib/unbuild/early-error.mjs b/lib/unbuild/early-error.mjs
@@ -231,7 +231,12 @@ const reportDuplicateEarlyError = (error, { root }) => {
           makeConditionalEffect(
             makeConditionalExpression(
               makeApplyExpression(
-                makeIntrinsicExpression("Object.hasOwn", path),
+                // Reflect.getOwnPropertyDescriptor instead of Object.hasOwn
+                // https://github.com/nodejs/node/issues/52720
+                makeIntrinsicExpression(
+                  "Reflect.getOwnPropertyDescriptor",
+                  path,
+                ),
                 makePrimitiveExpression({ undefined: null }, path),
                 [
                   makeIntrinsicExpression("aran.global", path),

diff --git a/test/262/cursor.json b/test/262/cursor.json
@@ -1 +1 @@
-{"stage":"empty-emulate","index":4853,"target":null}
+{"stage":"empty-emulate","index":6714,"target":null}
diff --git a/test/262/stages/empty-emulate.manual.json b/test/262/stages/empty-emulate.manual.json
@@ -351,11 +351,5 @@
     "test/language/statements/let/dstr/ary-ptrn-elem-id-iter-val-array-prototype.js",
     "test/language/statements/try/dstr/ary-ptrn-elem-id-iter-val-array-prototype.js",
     "test/language/statements/variable/dstr/ary-ptrn-elem-id-iter-val-array-prototype.js"
-  ],
-  "https://github.com/nodejs/node/issues/52720": [
-    "test/built-ins/Array/prototype/methods-called-as-functions.js",
-    "test/built-ins/BigInt/prototype/toString/thisbigintvalue-not-valid-throws.js",
-    "test/built-ins/BigInt/prototype/valueOf/return.js",
-    "test/built-ins/BigInt/prototype/valueOf/this-value-invalid-object-throws.js"
   ]
 }
diff --git a/test/262/stages/empty-emulate.mjs b/test/262/stages/empty-emulate.mjs
@@ -14,8 +14,6 @@ import {
 
 const { JSON, URL } = globalThis;
 
-console.log(generate(setup(SETUP_CONFIG)));
-
 /** @type {test262.Stage} */
 export default {
   requirement: ["identity", "parsing"],

diff --git a/yoyo.mjs b/yoyo.mjs
@@ -4,8 +4,8 @@ console.log(
     `
       "use strict";
       ({
-        hasOwn: Object.hasOwn(globalThis, "toLocaleString"),
-        descriptor: Reflect.getOwnPropertyDescriptor(globalThis, "toLocaleString"),
+        hasOwn: Object.prototype.hasOwnProperty.call(globalThis, "toString"),
+        descriptor: Reflect.getOwnPropertyDescriptor(globalThis, "toString"),
       });
     `,
     createContext(),