Skip to content

Update SLSA generator, implement first instructions, add helper decoders#2

Merged
lachlanharrisdev merged 1 commit intomainfrom
initial-instructions
Sep 22, 2025
Merged

Update SLSA generator, implement first instructions, add helper decoders#2
lachlanharrisdev merged 1 commit intomainfrom
initial-instructions

Conversation

@lachlanharrisdev
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the first instructions for an LC-3 virtual machine and updates the SLSA security generator. The implementation adds basic instruction execution infrastructure with support for ADD, AND, NOT, and TRAP operations, replacing placeholder code with functional instruction processing.

  • Updates the SLSA generator to v2.1.0 for improved security provenance
  • Implements core instruction execution logic with decode helpers and trap routines
  • Establishes the main execution loop to fetch and execute instructions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/slsa-generator.yml Updates SLSA generator version for security provenance
Makefile Adds FLAGS variable to compiler invocation
src/main.c Implements instruction fetch/execute loop and adds cleanup handlers
include/hardware.h Defines LC-3 instruction opcodes and switches from Phantom-18 ISA
include/instructions.h Adds instruction decode macros and function prototypes
src/instructions.c Implements instruction execution functions and trap routines

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lachlanharrisdev lachlanharrisdev merged commit 05d1733 into main Sep 22, 2025
1 check passed
@lachlanharrisdev lachlanharrisdev deleted the initial-instructions branch September 22, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants