Skip to content

Conversation

lacework-releng
Copy link
Contributor

@lacework-releng lacework-releng commented Mar 31, 2022

Release Notes

Another day, another release. These are the release notes for the version v1.5.1.

Documentation Updates

Other Changes

@cirego
Copy link
Contributor

cirego commented Mar 31, 2022

@afiune, can you either give the 👍 on this and/or provide me with write access to this repo? Thanks!

p.s. Sorry for creating two PRs (#45), it looks like bug changes don't show up in release notes and that confused me.

@afiune
Copy link
Contributor

afiune commented Mar 31, 2022

@cirego oh, I should have caught that during review. bug: is not a valid change type, here are the valid types:

https://github.com/lacework/terraform-kubernetes-agent/blob/main/DEVELOPER_GUIDELINES.md#commit-message-standard

I'll have to manually modify the Release notes, I'll do that now. 😭

@cirego
Copy link
Contributor

cirego commented Mar 31, 2022

@cirego oh, I should have caught that during review. bug: is not a valid change type, here are the valid types:

https://github.com/lacework/terraform-kubernetes-agent/blob/main/DEVELOPER_GUIDELINES.md#commit-message-standard

I'll have to manually modify the Release notes, I'll do that now. sob

Oh, it should have been fix or docs. My bad.

Signed-off-by: Lacework <tech-ally@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-157273467

@afiune
Copy link
Contributor

afiune commented Mar 31, 2022

@cirego fixed it!

@afiune afiune merged commit fb3413d into main Mar 31, 2022
@afiune afiune deleted the release branch March 31, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants