Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic AWS SSM command to install and configure Lacework agent #3

Merged
merged 5 commits into from
Feb 25, 2021

Conversation

JPLachance
Copy link
Contributor

This is the naive implementation that assumes many things about targeted hosts. Multiple TODOs were added to guide future improvements.

Signed-off-by: Jean-Philippe Lachance jplachance@coveo.com

…he Lacework agent

This is the naive implementation that assumes many things about targeted hosts. Multiple TODOs were added to guide future improvements.

Signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
@scottford-lw scottford-lw requested a review from afiune February 24, 2021 16:46
Demonstrate how to use the AWS SSM Command in our default example.

Signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JP!!! This work is just so awesome!

tenor-55917718

I left a few comments and a few suggestions, let me know if you want to tackle them or you want us to take this over and push the extra mile. Up to you! 🙌🏽

setup_lacework_agent.sh Outdated Show resolved Hide resolved
examples/default/main.tf Outdated Show resolved Hide resolved
target_type = "/AWS::EC2::Instance"

content = jsonencode({
schemaVersion = "2.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! I was worried about updates after the document has been created. Nicely done!

@@ -0,0 +1,54 @@
resource "aws_ssm_document" "setup_lacework_agent" {
name = "${var.aws_resources_prefix}setup-lacework-agent"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does SSM document names have a limit? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no idea!

@afiune afiune closed this Feb 24, 2021
@afiune afiune reopened this Feb 24, 2021
fix(command): Fix tags in the config.json file setup
refactor(command): Always override the config.json file

Signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
refactor(command): Always override the config.json file

Signed-of-by: Jean-Philippe Lachance <jplachance@coveo.com>
Signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
@afiune afiune closed this Feb 24, 2021
@afiune afiune reopened this Feb 24, 2021
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic Work JP!!!

tenor-215685501

@afiune afiune changed the title Add a basic AWS SSM command to install and configure the Lacework agent feat: add basic AWS SSM command to install and configure Lacework agent Feb 25, 2021
@afiune afiune merged commit 73f85b6 into lacework:main Feb 25, 2021
@afiune afiune mentioned this pull request Feb 25, 2021
@JPLachance JPLachance deleted the feat/initial-command branch March 5, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants