Skip to content

Add control for creating and attaching policies #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

rnikoopour
Copy link

@rnikoopour rnikoopour commented Oct 28, 2021

Issue:
I am unable to use an existing role with policies managed outside of the module.

Description:
By adding a new input called create_policies the module users can control whether the policies in the module are created an attached.

Also ran terraform format against the two files worked it.

Additional Info:
create_policies defaults to true so there should be no impact to existing users.

@afiune
Copy link
Contributor

afiune commented Oct 28, 2021

Make it so! 🙌🏽

@rnikoopour
Copy link
Author

Oof I forgot to change something to support the new count argumants. Gimme a minute to submit a patch to this PR.

@afiune
Copy link
Contributor

afiune commented Oct 28, 2021

Yeah the pipeline got the same thing you pointed out:

Screen Shot 2021-10-29 at 1 13 30 AM

Looking forward to this contribution! 💯

@afiune
Copy link
Contributor

afiune commented Oct 29, 2021

Make it so! ( 👈🏽 This is to execute our pipelines 😂)

One thing, in order to accept this PR, we need you to sign your commits for security reasons. This is part of our development and contributing guidelines: https://github.com/lacework/terraform-aws-config/blob/main/DEVELOPER_GUIDELINES.md#signing-commits

@dmurray-lacework
Copy link
Collaborator

@afiune @rnikoopour
This PR looks ready to go. But is still missing signed commits.
https://github.com/lacework/terraform-aws-config/blob/main/DEVELOPER_GUIDELINES.md#signing-commits

@afiune
Copy link
Contributor

afiune commented Apr 13, 2022

@rnikoopour Hello there! 👋🏽 We are hoping to get this in as soon as you can sign your commits.

(this is just a kind reminder 😜)

If you prefer, we can pull down your changes, rebase them and add one of our signatures, then merge it on a new pull request. Please, let us know your preference. Thanks again for your contribution. 🏅

@kkirpichnikov-collibra
Copy link

@rnikoopour Hello there! 👋🏽 We are hoping to get this in as soon as you can sign your commits.

(this is just a kind reminder 😜)

If you prefer, we can pull down your changes, rebase them and add one of our signatures, then merge it on a new pull request. Please, let us know your preference. Thanks again for your contribution. 🏅

Looks like it's time to do it and there are no objections from @rnikoopour

@afiune
Copy link
Contributor

afiune commented Dec 27, 2022

We waited a long time 😅 - Closing in favor of #55

Thanks @rnikoopour 🥳

@afiune afiune closed this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants