Update calibrate_lens_shading to set geq to max #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update calibrate_lens_shading to set geq to max by calling self.set_static_green_equalisation() Tested on my microscope, sets the value as expected
Update calibrate_lens_shading to set geq to max
julianstirling
requested changes
Mar 3, 2025
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
Nice, thanks @JohemianKnapsody. Can you confirm:
- You have run this on a microscope
- You have clicked save, shut down the microscope and that it is still set on reboot?
Collaborator
Author
Have run on a microscope, saved and power cycled. This seems to be as persistent as the other camera settings, yes |
julianstirling
approved these changes
Mar 3, 2025
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
Thanks for checking Joe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update calibrate_lens_shading to set geq to max by calling self.set_static_green_equalisation()
Tested on my microscope, sets the value as expected
Closes #14