Skip to content

Response reset size #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2015
Merged

Response reset size #86

merged 1 commit into from
May 28, 2015

Conversation

CaptainCodeman
Copy link
Contributor

Very minor but the logged response size accumulated with each request producing the following for the 'hello world' example (note last column):

2015/05/27 20:46:49 GET / 200 0 14
2015/05/27 20:46:49 GET / 200 0 28
2015/05/27 20:46:49 GET / 200 0 42
2015/05/27 20:46:50 GET / 200 0 56

Setting the size to 0 when the response is reset produces the expected result:

2015/05/27 20:49:13 GET / 200 0 14
2015/05/27 20:49:14 GET / 200 0 14
2015/05/27 20:49:14 GET / 200 0 14
2015/05/27 20:49:14 GET / 200 0 14

Set size to 0 when response reset

Prevents logged size accumulating with each request
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 81.66% when pulling 87b24d3 on CaptainCodeman:response-size into 4159cef on labstack:master.

vishr added a commit that referenced this pull request May 28, 2015
@vishr vishr merged commit 7d518ce into labstack:master May 28, 2015
@vishr
Copy link
Member

vishr commented May 28, 2015

@CaptainCodeman Thanks, do you mind joining gitter chat for future communication?

@CaptainCodeman CaptainCodeman deleted the response-size branch May 28, 2015 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants