Skip to content

Conversation

@usk81
Copy link
Contributor

@usk81 usk81 commented Feb 10, 2017

No description provided.

@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage increased (+2.8%) to 88.048% when pulling 2995614 on usk81:request-id into a8b6864 on labstack:master.

@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 85.198% when pulling 3b0ffba on usk81:request-id into a8b6864 on labstack:master.

@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 85.198% when pulling 0c7c1b7 on usk81:request-id into a8b6864 on labstack:master.

@ungureanuvladvictor
Copy link

Any update on this ?

@vishr
Copy link
Member

vishr commented Mar 6, 2017

@usk81 Do you mind using gommon/random to generate an ID? may be 32 chars.

@vishr vishr merged commit 0c7c1b7 into labstack:master Mar 6, 2017
@vishr
Copy link
Member

vishr commented Mar 6, 2017

@usk81 thanks for your contribution 🎉

@usk81
Copy link
Contributor Author

usk81 commented Mar 21, 2017

@vishr Sorry, I didn't know gommon/random.
gommon/random can generate IDs longer than the UUID, but UUID is more popular.

@vishr
Copy link
Member

vishr commented Mar 21, 2017

@usk81 No worries, this was taken care of. The config allows you to use a customized generator, so UUID should not a be problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants