Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set cookie to request #2691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-sam-randall
Copy link

When setting a cookie to response also set it the request so that it can be retrieved in the same request.

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are changing the method contract here.

// SetCookie adds a `Set-Cookie` header in HTTP response.

says that cookie is set for the Response. Response and Request are reasonably different things that to assume if cookie exists in Response it would/should exists in Request is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants