Skip to content

Check whether is nil before invoking centralized error handling. - #2429

Merged
aldas merged 1 commit into
labstack:masterfrom
px3303:master
Apr 15, 2023
Merged

aldas merged 1 commit into
labstack:masterfrom
px3303:master

Conversation

@px3303

@px3303 px3303 commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

Fix recover and request_logger middlewares omit checking err before calling centralized errors.

@px3303 px3303 closed this Apr 7, 2023
@px3303 px3303 reopened this Apr 7, 2023

@aldas aldas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Apr 15, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a7802ea) 92.87% compared to head (51c6b2a) 92.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2429   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files          39       39           
  Lines        4521     4521           
=======================================
  Hits         4199     4199           
  Misses        234      234           
  Partials       88       88           
Impacted Files Coverage Δ
middleware/recover.go 83.01% <100.00%> (ø)
middleware/request_logger.go 97.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas
aldas merged commit de1c798 into labstack:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants