Skip to content

add supprt for go1.20 http.rwUnwrapper - #2425

Merged
aldas merged 1 commit into
labstack:masterfrom
imxyb:feature/unwrap
Apr 6, 2023
Merged

aldas merged 1 commit into
labstack:masterfrom
imxyb:feature/unwrap

Conversation

@imxyb

@imxyb imxyb commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Support ResponseController for Go 1.20

@codecov

codecov Bot commented Mar 28, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f22ba67) 92.87% compared to head (f2019e7) 92.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2425   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files          39       39           
  Lines        4519     4521    +2     
=======================================
+ Hits         4197     4199    +2     
  Misses        234      234           
  Partials       88       88           
Impacted Files Coverage Δ
response.go 86.36% <100.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas

aldas commented Mar 31, 2023

Copy link
Copy Markdown
Contributor

@imxyb this looks OK but could you add one test for it.

@imxyb

imxyb commented Apr 3, 2023

Copy link
Copy Markdown
Contributor Author

@imxyb this looks OK but could you add one test for it.

done

@aldas aldas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas
aldas merged commit a7802ea into labstack:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants