Skip to content

update tests - #2275

Merged
aldas merged 14 commits into
labstack:masterfrom
Kamandlou:master
Oct 6, 2022
Merged

aldas merged 14 commits into
labstack:masterfrom
Kamandlou:master

Conversation

@Kamandlou

Copy link
Copy Markdown
Contributor

No description provided.

@Kamandlou

Copy link
Copy Markdown
Contributor Author

@vishr

Comment thread context.go Outdated
Comment thread bind_test.go Outdated
@Kamandlou Kamandlou changed the title rename variable because collides with imported package name update tests Oct 6, 2022
@Kamandlou
Kamandlou requested a review from aldas October 6, 2022 07:36
Comment thread bind_test.go Outdated
@Kamandlou

Kamandlou commented Oct 6, 2022 •

Copy link
Copy Markdown
Contributor Author

There are two left assert.New because assertBindTestStruct function and because we can't use generic

@Kamandlou
Kamandlou requested a review from aldas October 6, 2022 08:00
Comment thread bind_test.go Outdated
@Kamandlou
Kamandlou requested a review from aldas October 6, 2022 08:15

@aldas aldas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas
aldas merged commit 4c44305 into labstack:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants