Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a custom error handler to key-auth middleware #1847

Merged
merged 3 commits into from
May 8, 2021

Conversation

hyacinthus
Copy link
Contributor

link to #1846

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1847 (7543e88) into master (bb7f222) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
+ Coverage   89.57%   90.18%   +0.61%     
==========================================
  Files          32       32              
  Lines        2686     2690       +4     
==========================================
+ Hits         2406     2426      +20     
+ Misses        180      169      -11     
+ Partials      100       95       -5     
Impacted Files Coverage Δ
middleware/key_auth.go 96.55% <100.00%> (+29.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7f222...7543e88. Read the comment docs.

@hyacinthus
Copy link
Contributor Author

I'll update doc after pr accepted.

And it's hard to add a test to this patch...

@aldas aldas added this to the v4.3 milestone Apr 12, 2021
middleware/key_auth_test.go Outdated Show resolved Hide resolved
@hyacinthus hyacinthus requested a review from aldas April 14, 2021 13:46
hyacinthus added a commit to hyacinthus/echox that referenced this pull request Apr 15, 2021
@aldas aldas merged commit 7256cb2 into labstack:master May 8, 2021
aldas pushed a commit to labstack/echox that referenced this pull request May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants