Skip to content

Update README.md with an updated Benchmark #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2020

Conversation

pafuent
Copy link
Contributor

@pafuent pafuent commented Nov 12, 2020

There is also a related PR to update the benchmark code

There is also a related [PR](vishr/web-framework-benchmark#3) to update the benchmark code
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1679 (f1a4cb4) into master (7a90304) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
+ Coverage   84.35%   84.72%   +0.37%     
==========================================
  Files          28       29       +1     
  Lines        1911     1938      +27     
==========================================
+ Hits         1612     1642      +30     
+ Misses        189      188       -1     
+ Partials      110      108       -2     
Impacted Files Coverage Δ
middleware/decompress.go 94.73% <0.00%> (ø)
middleware/cors.go 85.52% <0.00%> (+7.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a90304...f1a4cb4. Read the comment docs.

Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the system used for the benchmark as reference

E.g. "The benchmarks above were run on an AMD Ryzen 3800x system" or something like that
I always missed that part to make it more comparable.

@pafuent
Copy link
Contributor Author

pafuent commented Nov 23, 2020

Sure, but maybe I need to re run those benchmarks, due to new PR were merged to master.
BTW, @vishr, Could you please check my modifications to the Benchmark code?

@lammel
Copy link
Contributor

lammel commented Nov 23, 2020

Great @pafuent . Let me know, when you have updated the images.

Maybe we should add a docs folder and keep the images in git (in a docs subfolder or something) instead of using an external service, but that is another issue.

(vishr was not very active the last weeks, not sure he will be able to review anytime soon)

@pafuent pafuent self-assigned this Nov 26, 2020
@lammel
Copy link
Contributor

lammel commented Dec 7, 2020

@pafuent Are the image links now updated and the PR is ready to merge?

@lammel lammel merged commit 06a9480 into labstack:master Dec 12, 2020
@pafuent pafuent deleted the update_benchmark_to_newer_versions branch December 14, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants