Fixes the uses of caret(^) in rewrite regex #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1588 +/- ##
==========================================
+ Coverage 85.23% 85.24% +0.01%
==========================================
Files 28 28
Lines 2181 2183 +2
==========================================
+ Hits 1859 1861 +2
Misses 208 208
Partials 114 114
Continue to review full report at Codecov.
|
lammel
reviewed
Jul 23, 2020
|
Sorry for being late, going to review again soon. |
|
@choyri Thanks for your contribution and cleaning up the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1573
When use
QuoteMeta，^will be replaced to\^, and than out of action as regex element.