Relax content-type matching #149
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the Content-Type header matching in the context.Bind method.
Angular 1.x sets the header to
application/json;charset=utf-8
(note the lack of any space after the;
) so checking that the stringapplication/json; charset=utf-8
starts with that header fails which prevents Angular$resource
or$http
etc... being used without extra client work.I think the match should be the other way round - check if the header starts with simpler
application/json
string instead and ignore anything else.I added the
applicationJSON
const becauseApplicationJSON
is used for other things as well. It's not a very good name and should probably be calledApplicationJSONPrefix
or something similar but probably shouldn't be exported. I'm sure there is some official Content-Type parsing / matching rule somewhere though so we should probably follow that.