Fix param value bug #1467
Merged
Fix param value bug #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
==========================================
+ Coverage 84.44% 84.45% +<.01%
==========================================
Files 27 27
Lines 2090 2091 +1
==========================================
+ Hits 1765 1766 +1
Misses 212 212
Partials 113 113
Continue to review full report at Codecov.
|
3 tasks
Member
|
@asahasrabuddhe Do you mind adding a test around it? |
Contributor
Author
Done 👍 |
vishr
approved these changes
Jan 1, 2020
Contributor
Author
|
Thanks for this @vishr Let me know when we can speak about taking the project forward in the right direction |
Member
|
Absolutely. Let me reach out key contributors and figure it out.
… On Jan 1, 2020, at 9:33 AM, Ajitem Sahasrabuddhe ***@***.***> wrote:
Thanks for this @vishr <https://github.com/vishr> Let me know when we can speak about taking the project forward in the right direction
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1467?email_source=notifications&email_token=AACMVNFY7NYO3LJSBVTPADTQ3THXLA5CNFSM4KBTR6RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5JHCY#issuecomment-570069899>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACMVNA6ZENIAEE23RJPD3TQ3THXLANCNFSM4KBTR6RA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1466
@vishr I would appreciate you taking a look at this and merging this. This is a major regression and I think people would appreciate a quick release fixing this...