Fixed failing tests from param binder

[kolaente]

This pr fixes the failing tests from #1165. When I removed my param binder stuff, that specific test worked again, so think I can be sure my code is the problem here.

I'm not 100% sure why this fix works or why this even failed in the first place, any ideas are appreciated.

The tests were failing because of the call to val.Field(i) in bind.go:106. When this was called and the passed ptr variable was nil this function panicked. I don't understand enough of Go's reflect mechanisms to be able to tell why exactly this was the case, so my "fix" is more a workaround for the fact that the tests are failing.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@858270f). Click here to learn what that means.
The diff coverage is 60%.

@@            Coverage Diff            @@
##             master    #1353   +/-   ##
=========================================
  Coverage          ?   84.24%           
=========================================
  Files             ?       27           
  Lines             ?     2057           
  Branches          ?        0           
=========================================
  Hits              ?     1733           
  Misses            ?      210           
  Partials          ?      114

Impacted Files	Coverage Δ
bind.go	90.16% <60%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858270f...34000ea. Read the comment docs.

[kolaente]

@vishr Why did you close this?

[vishr]

@kolaente Because I fixed it in 8fb7b5b without a hack.

[kolaente]

@vishr so the issue was only in the way the map with the params was created?

[vishr]

No. I just removed some negative test for bind.

…

On Thu, Jun 27, 2019 at 11:00 AM kolaente ***@***.***> wrote: @vishr <https://github.com/vishr> so the issue was only in the way the map with the params was created? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1353?email_source=notifications&email_token=AACMVNEQPCBP3Q2CEPFPHZDP4T55NA5CNFSM4H2XSKMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYX5AKI#issuecomment-506449961>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACMVNFDJYYG54WOPXYFKKLP4T55NANCNFSM4H2XSKMA> .

[kolaente]

@vishr I see... If you say it's fine to do it like this...