Skip to content

Simplify Middleware Chain Creation #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Conversation

hemachandarv
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #1299 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
+ Coverage   84.21%   84.22%   +<.01%     
==========================================
  Files          26       26              
  Lines        1951     1952       +1     
==========================================
+ Hits         1643     1644       +1     
  Misses        202      202              
  Partials      106      106
Impacted Files Coverage Δ
echo.go 88.19% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775b2ee...4b92564. Read the comment docs.

@hemachandarv
Copy link
Contributor Author

@vishr May I request your review? This can be simplified further, as provided in #1265

@vishr vishr merged commit 08db4bd into labstack:master Mar 5, 2019
@vishr
Copy link
Member

vishr commented Mar 5, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants