Logger: default config missing double quato #1235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sueken5
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 26 26
Lines 1927 1927
=======================================
Hits 1572 1572
Misses 248 248
Partials 107 107
Continue to review full report at Codecov.
|
|
not missing, but the single double quote has been accidentally introduced. See history of changes and #1232 |
|
Hello there is a better one, https://github.com/labstack/echo/pull/1232/files, latency is a number. |
|
surely, https://github.com/labstack/echo/pull/1232/files is better. I close this pull request . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing double quato , so it is not json format.