Skip to content

fix href url from armor to echo #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2018
Merged

fix href url from armor to echo #1051

merged 1 commit into from
Jan 25, 2018

Conversation

wind0r
Copy link
Contributor

@wind0r wind0r commented Jan 25, 2018

image shows echo but links to armor.labstack.com.
i think this should be echo.labstack.com

@codecov
Copy link

codecov bot commented Jan 25, 2018

Codecov Report

Merging #1051 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1051   +/-   ##
=======================================
  Coverage   77.73%   77.73%           
=======================================
  Files          27       27           
  Lines        1922     1922           
=======================================
  Hits         1494     1494           
  Misses        301      301           
  Partials      127      127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b604040...c718102. Read the comment docs.

@vishr vishr merged commit 40cae83 into labstack:master Jan 25, 2018
@vishr
Copy link
Member

vishr commented Jan 25, 2018

@wind0r thanks for your contribution 🎉

vishr pushed a commit that referenced this pull request Mar 12, 2018
Enhancements:
    Implemented Response#After()
    Dynamically add/remove proxy targets
    Rewrite rules for proxy middleware
    Add ability to extract key from a form field
    Implemented rewrite middleware
    Adds a separate flag for the 'http/https server started on' message (#1043)
    Applied a little DRY to the redirect middleware (#1053) and tests (#1055)
    Simplify dep fetching (#1062)
    Add custom time stamp format #1046 (#1066)
    Update property name & default value & comment about custom logger
    Add X-Requested-With header constant
    Return error of context.File in c.contentDisposition
    Updated deps
    Updated README.md

Fixes:

    Fixed Response#Before()
    Fixed #990
    Fix href url from armor to echo (#1051)
    Fixed #1054
    Fixed #1052, dropped param alias feature
    Avoid redirect loop in HTTPSRedirect middleware (#1058)
    Fix deferring body close in middleware/compress test (#1063)
    Cleanup code (#1061)
    FIX - We must close gzip.Reader, only if no error (#1069)
    Fix formatting (#1071)
    Can be a fix for auto TLS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants