having trouble writing a customer logger middleware

[atbaig]

Description

I am trying to log some custom fields in my custom logger middleware. I took the code from middleware/logger.go and tried to modify it in my own repo. I am getting EOF after I do a c.Bind()

Expected behaviour

I am expecting it work normally

Actual behaviour

I get an EOF after I add the c.Bind()

Steps to reproduce

middleware/logger.go

Working code to debug

return func(next echo.HandlerFunc) echo.HandlerFunc {
return func(c echo.Context) (err error) {
//Begin Custom Code
r1 := &Request{}
if err = c.Bind(&r1); err != nil {
fmt.Println(err)
return err
}
//End Custom code
req := c.Request()
res := c.Response()
start := time.Now()
if err = next(c); err != nil {
c.Error(err) //This is where I get an EOF. If I remove the custom code everything works perfectly
}
Am I doing something wrong?

package main

func main() {
}

Version/commit

[mbn18]

Update

In my case the problem was caused by middleware that also used bind. Seems bind cannot be called more than once.
Any reason it is not accessible after first use?

Original problem

Have related issue

In one of my PUT request I get EOF

The request object is:

type RecommendationAddRequest struct {
	Xyz string `json:"xyz" validate:"required,gte=6"`
}

The binder is the default one:

	if err := c.Bind(reqObj); err != nil {
		println("error is:", err.Error())
		return false
	}

And it print out:

error is: code=400, message=EOF

The request is:

curl -X PUT \
  https://domain.com/api/whatever \
  -H 'authorization: Bearer some-string' \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -d '{
	"xyz": "ssss"
}'

Tried to switch to POST and etc. The odd thing is that I have other POST/PUT actions that do work as expected

[vishr]

Any reason it is not accessible after first use?

Bind() reads request body directly from the socket and once read it can't read again, hence the EOF error. You can look into this blog post as a workaround: https://medium.com/@xoen/golang-read-from-an-io-readwriter-without-loosing-its-content-2c6911805361

[arthurlataks]

@vishr Isn't it possible to restore body content during the Bind or should I implement custom Binder for that purpose? For now I implemented body data restore like it is done in the Body Dump MW (and well, like in the Medium post), which makes me think that this should be handled in the MW?