Can we make Graceful's ShutdownInitiated property public?

[mathvav]

Graceful's server struct exposes a ShutdownInitiated func() variable that is called when the program is shutting down.

Can we somehow expose this variable to the end user? My software runs several goroutine processes that I'd love to send a channel value to in order to let them clean up safely.

[paganotoni]

@vishr would adding something like:

func (e *Echo) ShutdownInitiated() func() {
	return e.server.ShutdownInitiated
}

to the Echo struct be enough to cover this issue ?

[vishr]

Do we want to expose third-party properties? Tomorrow Go might come up with shutdown process. Is there a better way?

[mathvav]

@vishr Are there any proposals in progress for such a thing? If not, it's not like anything will happen for at least several months.

[mathvav]

@apaganobeleno a few issues with that code:

• There is also a HTTPS server that needs to be separately accessed.
• AFAIK, you would need to return a pointer to the function, not the function itself in order to be able to set the function. The better way than returning a pointer, however, would just be an Echo function to set the ShutdownInitiated function directly.

[mathvav]

@vishr would a PR be accepted?

[paganotoni]

@Anon-Penguin thanks for the feedback, you're right, it lacks support for the HTTPS server property.

@vishr i see your point and given Go will come up with shutdown process, how will Echo support < 1.8 versions of Go once 1.8 comes out ?.

[vishr]

@apaganobeleno That's the reason I don't want to expose third party properties via Echo

[mathvav]

This issue may depend somewhat on #797.

Regardless, here's a proposal:

1. Add a start function that does NOT use Graceful
2. Panic for calls to the shutdown methods (if needed: it might already panic if the pointer is nil—I need to reread the code there)
3. For anyone who wants extra code, they can use the Graceful-free start and wrap it in a Graceful object outside of Echo to do all of the hard lifting

---

That's the reason I don't want to expose third party properties via Echo

It seems to me that you shouldn't directly expose the Graceful properties, yes. But, I don't see there being harm in duplicating the Graceful API (or important parts of it) so that it can be switched over without changing the external API when we want to drop Go <=1.7 support (in a few years).

[mathvav]

I'm going to close this because this has evolved into the same topic as #797. Please continue conversation there (cc @apaganobeleno)