After fix for #479 param names aren't accessible :(

[fat]

Hi

After upgrading to latest v3 i'm noticing im unable to parse my params on several routes.

Suspecting this may be the change which is causing the pain… c59b79d

At any rate, I have a route like:

/:version/playlists/:playlistID/follow

and when loggin:

fmt.Println(c.ParamValues())
fmt.Println(c.ParamNames())

i'm getting:

4:54:57 PM web.1    |  [v1 647a967c-a697-43ec-6ede-a6bfccfd2036 ]
4:54:57 PM web.1    |  []

This is problematic as im nolonger able to access my params by name in my code ;_;

Any help would be greatly appreciated, thanks!

[fat]

whats' really driving me crazy is i have two routes:

    r.POST("users/:userID/follow", followUserHandler(s))
    r.POST("playlists/:playlistID/follow", followPlaylistHandler(s))

which seemed to be defined almost identically, but only doesn't work for user.

[fat]

if i revert this change specifically: c59b79d#diff-56c3bb2da6c5ecf6872e89a554944453L173

my bug goes away

[vishr]

Can you provide some routes to reproduce the problem? I am not able to reproduce this issue with provided routes.

[fat]

is there an email address, i can send you more details on our routes (rather then posting here)…

[fat]

also, tomorrow i can try to come up with a better test case

[vishr]

Yea, a working example would speed up debugging.

[fat]

yah makes sense…

[fat]

ok i think i've narrowed down why…

so we have two groups:

p := s.Echo.Group("/:version/")
p.Use(OptionalJWTAuth(s))
p.GET("users/:userID/following", getFollowingHandler(s))
p.GET("users/:userID/followedBy", getFollowedByHandler(s))

and

r := s.Echo.Group("/:version/")
r.Use(JWTAuth(s))
r.POST("users/:userID/follow", followUserHandler(s))
r.DELETE("users/:userID/follow", unfollowUserHandler(s))

if i leave like above, the post and delete don't get the paramnames, but if i comment out those two gets above, they work.

Hopefully that helps!

[vishr]

Thank you, I will look into it.

[fat]

dope thanks @vishr

[vishr]

Please verify