Skip to content

Middleware chain no longer traversed if no route found #65

Closed
@Nomon

Description

@Nomon

73fa05f (https://github.com/labstack/echo/blob/master/echo.go#L323) makes ServeHTTP skip all middlewares if no matching route is found.
This breaks among other things logging of 404 requests with logger middleware, also other middlewares we use like CORS/preflight for options requests do no longer work as we have no matching Options routes. Is this intended (and future) behavior to skip all the middlewares if no matching route is found or is it a bug?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions