Static handler broken

[CaptainCodeman]

e.Static() seems to have broken. With a very simple setup to serve an index page and script it no longer works and returns 'not found' for requests that should be served by the static handler. If the e.Index method is commented out then it works so some interaction with how the routes are built up or searched (?)

e.Index("public/index.html")
e.Static("/scripts", "public/scripts")

[CaptainCodeman]

Digging into this a little more, it seems any route using the 'match any' wildcard has stopped working (e.g. "/somepath/param"). The Static handler adds the "/" part to the route.

[vishr]

Did you try with the latest code? I tried to fix it.

[CaptainCodeman]

Looks like that fixed it - many thanks !! 👍

Not sure if this is a related issue or I'm just using it wrong but I noticed that the following works ok:

api.Get("/folders", folders)
api.Get("/folders/*", folder)

... but if the first path has a trailing slash then it causes an error, i.e.

api.Get("/folders/", folders)
api.Get("/folders/*", folder)

2015/05/01 11:52:28 http: panic serving [::1]:54452: runtime error: slice bounds out of range
goroutine 34 [running]:
net/http.func·011()
    /usr/local/go/src/net/http/server.go:1130 +0xbb
github.com/labstack/echo.(*router).Find(0xc20800a460, 0xc208108000, 0x3, 0xc208108004, 0xb, 0xc208040410, 0xc20800a9d0, 0xc20805c000)
    /go/src/github.com/labstack/echo/router.go:239 +0x214
github.com/labstack/echo.(*Echo).ServeHTTP(0xc20805c000, 0x76f670, 0xc2081500a0, 0xc208106750)
    /go/src/github.com/labstack/echo/echo.go:296 +0xd0
net/http.serverHandler.ServeHTTP(0xc208070a80, 0x76f670, 0xc2081500a0, 0xc208106750)
    /usr/local/go/src/net/http/server.go:1703 +0x19a
net/http.(*conn).serve(0xc208150460)
    /usr/local/go/src/net/http/server.go:1204 +0xb57
created by net/http.(*Server).Serve
    /usr/local/go/src/net/http/server.go:1751 +0x35e

I'm totally fine using the 1st version, just an FYI if that wasn't intended or someone else runs into the same thing or it needs to be mentioned in the docs.

[CaptainCodeman]

BTW: The reason for having the trailing slash is simply convenience as it's the angular default. so it saves having to add $resourceProvider.defaults.stripTrailingSlashes = true; in the client code.

[vishr]

I am aware of the problem and that's the reason issue is still open. Thanks for your input, I will work on it at next opportunity.

[CaptainCodeman]

Thanks @vishr - really love this package (after trying every golang web framework, LOL) so let me know whenever you need me to test anything out.

I also discovered that the NotFoundHandler doesn't seem to be working right too - the overridden handler never gets called (returns '404 page not found' no matter what) and if the request doesn't contain a '/' then it causes a panic.

[vishr]

@CaptainCodeman Cool

[vishr]

fcbdaae
@CaptainCodeman Fixed routes you mentioned in the example. Custom not found handler test passes. FYI http://labstack.github.io/echo/guide/#customization, the custom not found handler is only called by router incase it doesn't find any matching path. I am still working on providing an option to strip trailing slash.

[CaptainCodeman]

Thanks @vishr - I'll try it out and report back

[CaptainCodeman]

All seems to be working great 👍

[vishr]

18dcc4b