echo.Bind() Error

[instance-oom]

At line 183 of echo.go. The code strings.HasPrefix(ct, ApplicationJSON) always return false,if my content-type is application/json. I think it's the ApplcationJson = "application/json; charset=utf-8" at line 94 cause it.And ifound the old version's ApplicationJson is "application/json",why change it?

[pandex]

Yes, I noticed this too with c.Bind() from json body. Totally borks json input.

[vishr]

The changes were made to fix #135.

[instance-oom]

There has a another problem. When the request.body has no content , the echo.bind() will throw a exception of EOF. Maybe should to return it if err != nil && err != io.EOF.

[vishr]

We should not call bind when there is no body 😄 but yea, it should be handled gracefully. I will take care of it.

[instance-oom]

thanks :）

[vishr]

I think the default behavior is correct, it's the error returned, which should be handled by handler or more idiomatically by centralized http error handler.

[instance-oom]

Yes, I think you are right. Thanks any way!

[pandex]

A bit confused here, what exactly is the current status of this?
Whether my json request is

contentType: "application/json; charset=utf-8" or
contentType: "application/json"

for err := c.Bind(myStruct), I still get:

err: echo ⇒ unsupported media type

and c.Bind(myStruct) is empty.

[vishr]

It should work in both cases, can you show some code to reproduce the issue?

[pandex]

I updated github.com/labstack/echo two minutes ago, again, now it's working. Thanks.