Defaulting to index.html

[syntaqx]

Hey guys, pretty new to working with echo. Loving everything I'm seeing so far, but I ran into a very interesting issue that I thought might be worth taking a look at.

Consider the following:

e := echo.New()
e.Index("public/index.html")
e.Run(":8080")

Then, visiting http://localhost:8080 , you get a Forbidden response, only seeing the correct value when you visit http://localhost:8080/index.html

Maybe it's just my naive understanding of the proper way of doing this, but wouldn't it be ideal to allow the Index func to be able to properly serve index files (similar to DirectoryIndex in apache) rather than needing to wrap this in an additional func?

[vishr]

Can you check how is it different then examples/website? Exposing Index API gives us flexibility to use any file name and location. Echo internally uses http.FileServer to server all static files which most likely behaves like apache and similar servers. We intentionally disabled directory listing in Echo to prevent unnecessary listing of files incase index file is not present, hence this behavior. Let me know your thoughts.

[syntaqx]

Ah, so the error actually occurs from an additional line on my end (sorry for not including it in the initial example) - Here is the full snippet:

e.Index("public/index.html")
e.Favicon("public/favicon.ico")
e.Static("/", "public")

The issue here is actually specific to the e.Static, reproducible by just using:

e.Static("/", "public")

So, I guess what I would change my issue to is:

When binding a static directory, would it be ideal to provide DirectoryIndex support outside of specifically mentioning the index.html?

The examples/website serves the public/scripts directory specifically, but there's a lot of cases where binding an entire public directory would be a lot less development overhead (ie, just serve everything in here). Not needing to specify the index.html would make it all the more beautiful (or whatever DirectoryIndex is needed)

[vishr]

I got your point. I will modify API to return index.html incase directory requested.

[syntaqx]

Awesome! Sorry for the over elaboration, I don't comment on GitHub too much so I wasn't sure if I was being clear. Excited to see this!

[benpate]

Thanks for making progress on this. I've been using echo for an app in development for a while, and a recent change with the static file hosting has broken my project. I believe your latest commit is working on this issue, but I'm still having trouble with static files.

Here's my scenario. Calling http://servername/foldername still responds with the index.html from the root level, not from within the folder. This is causing loads of trouble for me. I believe the standard behavior should be to display the index.html from folder it's calling, NOT from the root level. Hopefully this makes sense. If not, here's my shot at a demo app:

I've made a simple test app that serves a single example directory. Unfortunately, I can't figure out how to upload a .zip file, so I'm just going to inline the code here. It shouldn't be too bad:

main.go

package main

import (
    "github.com/labstack/echo"
    "net/http"
)

func main() {

    // Initialize router
    router := echo.New()
    router.Static("/", "www")

    http.ListenAndServe(":8080", router)
}

Inside there /www folder, there is a demo index.html file and another folder called "folder". Inside "folder" is another index.html file. They look like this:

/www/index.html

I am root-index.html

/www/folder/index.html

I am folder-index.html

Here's the confusion
I get different, inconsistent results based on the URLs that I use.

URL	Result	Success?
http://localhost:8080/	I am root-index.html	OK
http://localhost:8080/folder	I am root-index.html	ERROR (should be folder-index.html)
http://localhost:8080/folder/index.html	I am folder-index.html	OK

[syntaqx]

@benpate Totally agree with what you. I was hoping the fix that happened would fix that sort of behavior, but did not have that particular type of issue on my end (only working with a root index). Hopefully @vishr can come up with something clever.

[syntaqx]

@vishr Seems like this is fixed by changing

https://github.com/labstack/echo/blob/master/echo.go#L341

To:

f, err = fs.Open(file + "/index.html")

Can anyone else confirm this?

[benpate]

Yes. This is working for me, too. Thanks for digging in and finding the solution to this!

[syntaqx]

Looks like this fix doesn't work out for golang on Windows

Still digging into as to what the issue is, but figured it was worth re-opening this until it can be diagnosed.