add new github.com/labstack/echo-contrib/otelecho/v5 sub-module#141
add new github.com/labstack/echo-contrib/otelecho/v5 sub-module#141vadimi wants to merge 1 commit intolabstack:masterfrom
github.com/labstack/echo-contrib/otelecho/v5 sub-module#141Conversation
This version performs the same instrumentation as previously available `otelecho` in `opentelemetry-go-contrib` repo, but with echo v5 support v5 sub-directory is used specifically in case of new v6, v7, etc versions of echo come out in the future
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 63.77% 67.69% +3.91%
==========================================
Files 9 9
Lines 969 585 -384
==========================================
- Hits 618 396 -222
+ Misses 308 157 -151
+ Partials 43 32 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just a quick heads-up that I will be reviewing this over the weekend. |
|
Thanks, this PR is heavily needed and is our only blocker to upgrade to |
|
Update: I did review this PR on Saturday+Sunday and decided that I need to research more on that semconv package part and probably do some refactoring. I do not feel comfortable maintaining it in current form. Let's see what progress I have on Wednesday. Currently this issue is on top of my Echo list. |
This version performs the same instrumentation as previously available
otelechoinopentelemetry-go-contribrepo, but with echo v5 supportv5 sub-directory is used specifically in case of new v6, v7, etc versions of echo come out in the future