Skip to content

Conversation

@Lee-Minjea
Copy link

related : #125

Add an errorToStatusCodeResolver option to the MiddlewareConfig that resolves error to status code.
Default behavior should remain as it is, referencing echo.HTTPError.

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.77%. Comparing base (e3d5d99) to head (1e69e54).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
echoprometheus/prometheus.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   64.08%   63.77%   -0.32%     
==========================================
  Files           9        9              
  Lines         944      969      +25     
==========================================
+ Hits          605      618      +13     
- Misses        300      308       +8     
- Partials       39       43       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small remarks but overall I think this is nice addition.

@Lee-Minjea Lee-Minjea requested a review from aldas February 4, 2025 22:47
@Lee-Minjea Lee-Minjea force-pushed the feat/status_resolver branch 2 times, most recently from 3530fe5 to ba778c8 Compare February 5, 2025 04:52
@Lee-Minjea Lee-Minjea force-pushed the feat/status_resolver branch from ba778c8 to 1e69e54 Compare February 5, 2025 05:12
Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit d08b9ca into labstack:master Feb 6, 2025
12 checks passed
@Lee-Minjea Lee-Minjea deleted the feat/status_resolver branch February 7, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants